Closed Bug 1127772 Opened 9 years ago Closed 9 years ago

Add private destructor to D3D11TextureReporter.

Categories

(Core :: Graphics: Color Management, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla38

People

(Reporter: jacek, Assigned: jacek)

Details

Attachments

(1 file)

Attached patch fixSplinter Review
I found this in mingw build, where it hits an assertion in nsISupportsImpl.h. I also added a missing MOZ_FINAL to fix another warning.
Attachment #8557045 - Flags: review?(bgirard)
Attachment #8557045 - Flags: review?(bgirard) → review+
Here's a try run. When it's all green please set 'checkin-needed' in the whiteboard or ping me if it doesn't let you.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2770d31743f0
Thanks. It's green so I set checkin-needed. Is there something special about this patch? I'd usually just push it to m-i.
Keywords: checkin-needed
No, wasn't sure if you had commit access or not. Pushing yourself would of been fine.
https://hg.mozilla.org/mozilla-central/rev/76333b7b7dfd
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: