1127792 - Add a pref to globally disable compacting GC

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Jon Coppeard (:jonco)]

Attachment: add-compacting-pref

For testing purposes it would be useful to have a pref to enable/disable compacting GC in the browser.

This patch removes the current DisableCompactingGC() and IsCompactingGCEnabled() APIs that are currently unused and replaces them with a new GC parameter JSGC_COMPACTING_ENABLED.  This is the way our other preferences work.

I hooked up the javascript.options.mem.gc_compacting pref to use this.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: bug1127792-add-compacting-pref-workers

Also for workers.

Comment 2

[Jon Coppeard (:jonco)]

Comment on attachment 8557064 [details] [diff] [review]
add-compacting-pref

Requesting review for DOM changes.

Comment 3

[Andrew McCreight [:mccr8]]

Comment on attachment 8557064 [details] [diff] [review]
add-compacting-pref

Review of attachment 8557064 [details] [diff] [review]:
-----------------------------------------------------------------

r=me for the non-js/ changes

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 8557114 [details] [diff] [review]
bug1127792-add-compacting-pref-workers

Review of attachment 8557114 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/RuntimeService.cpp
@@ +404,1 @@
>                             JSGCParamKey aKey, uint32_t aValue)

Eek, embarrassing! Thanks for fixing.

Will you fix the indent on the second line too?

Comment 5

[Jon Coppeard (:jonco)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5a4b3f3a0bc3

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5a4b3f3a0bc3