Closed Bug 1127792 Opened 5 years ago Closed 5 years ago

Add a pref to globally disable compacting GC

Categories

(Core :: JavaScript: GC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox38 --- fixed

People

(Reporter: jonco, Assigned: jonco)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

For testing purposes it would be useful to have a pref to enable/disable compacting GC in the browser.

This patch removes the current DisableCompactingGC() and IsCompactingGCEnabled() APIs that are currently unused and replaces them with a new GC parameter JSGC_COMPACTING_ENABLED.  This is the way our other preferences work.

I hooked up the javascript.options.mem.gc_compacting pref to use this.
Attachment #8557064 - Flags: review?(terrence)
Also for workers.
Attachment #8557064 - Flags: review?(terrence) → review+
Comment on attachment 8557064 [details] [diff] [review]
add-compacting-pref

Requesting review for DOM changes.
Attachment #8557064 - Flags: review?(continuation)
Attachment #8557114 - Flags: review?(bent.mozilla)
Comment on attachment 8557064 [details] [diff] [review]
add-compacting-pref

Review of attachment 8557064 [details] [diff] [review]:
-----------------------------------------------------------------

r=me for the non-js/ changes
Attachment #8557064 - Flags: review?(continuation) → review+
Comment on attachment 8557114 [details] [diff] [review]
bug1127792-add-compacting-pref-workers

Review of attachment 8557114 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/RuntimeService.cpp
@@ +404,1 @@
>                             JSGCParamKey aKey, uint32_t aValue)

Eek, embarrassing! Thanks for fixing.

Will you fix the indent on the second line too?
Attachment #8557114 - Flags: review?(bent.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/5a4b3f3a0bc3
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.