Remove code marked as proprietary in BCMDHD

RESOLVED FIXED

Status

Firefox OS
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: gerv, Assigned: mwu)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

https://github.com/mozilla-b2g/codeaurora_kernel_msm/tree/master/drivers/net/wireless/bcmdhd contains code marked as the proprietary property of Broadcom. As per discussion with mwu in bug 1105380, we should kill this branch (i.e. make sure this code doesn't appear in our repos).

Gerv
mwu: any idea when you will be able to get to this?

Gerv

Comment 2

3 years ago
Michael, following up where are we with this?
Flags: needinfo?(mwu)
(Assignee)

Comment 3

3 years ago
Created attachment 8575652 [details] [review]
Stop using the master branch on codeaurora_kernel_msm

Not sure who really knows these old manifests anymore, but I guess it doesn't matter much anyway. I think these three manifests are the only ones left using master on codeaurora_kernel_msm. Once we get rid of all users, we can kill that branch.
Flags: needinfo?(mwu)
Attachment #8575652 - Flags: review?(lissyx+mozillians)
Looks good to me, I'm just checking with the few people still using unagi/otoro to make sure it still works for their usecase.
I just got confirmation that this will break building for otoro devices.
Comment on attachment 8575652 [details] [review]
Stop using the master branch on codeaurora_kernel_msm

Unago/Otoro builds will fail with:
> Adreno driver not found. Please download the Adreno 2xx User-mode Android ICS Graphics Driver (ARMv7) driver from

But since we don't care a lot anymore ...
Attachment #8575652 - Flags: review?(lissyx+mozillians) → review+
(Assignee)

Comment 7

3 years ago
That's not bustage from this patch though. Otoro devices always needed a separate gfx driver zip placed in the B2G directory. You can find a copy from the intranet page for Otoro.
(Assignee)

Comment 9

3 years ago
Master branch deleted.
(Assignee)

Comment 10

3 years ago
Bajaj, do you mind if I land this change on all applicable branches? This only affects obsolete devices (otoro) or devices that were only for experimentation (optimus L5, wasabi). We need to land this to fully remove code that we can't distribute.
Flags: needinfo?(bbajaj)
(In reply to Michael Wu [:mwu] from comment #10)
> Bajaj, do you mind if I land this change on all applicable branches? This
> only affects obsolete devices (otoro) or devices that were only for
> experimentation (optimus L5, wasabi). We need to land this to fully remove
> code that we can't distribute.

:mwu, all in for this change, please land with a=bajaj on applicable branches.
Flags: needinfo?(bbajaj)
(Assignee)

Comment 12

3 years ago
It looks like the removal of the master branch didn't reflect in our mirror - http://git.mozilla.org/?p=b2g/codeaurora_kernel_msm.git;a=summary , so I'll file a separate bug to trim out other branches once we're done with the upstream.
(Assignee)

Comment 14

3 years ago
Deleted all version branches of master.

 - [deleted]         v1.0.0
 - [deleted]         v1.0.1
 - [deleted]         v1-train
 - [deleted]         v1.2
 - [deleted]         v1.2f
 - [deleted]         v1.3
 - [deleted]         v1.3t
 - [deleted]         v1.4
 - [deleted]         v2.0
 - [deleted]         v2.1
 - [deleted]         v2.1s
 - [deleted]         v2.2
(Assignee)

Updated

3 years ago
Depends on: 1143982
(Assignee)

Comment 15

3 years ago
I think I've done everything I can do on my side. Follow up is necessary in bug 1143982 to remove these branches in our git mirror - http://git.mozilla.org/?p=b2g/codeaurora_kernel_msm.git;a=summary .
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.