1127815 - Remove code marked as proprietary in BCMDHD

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Gervase Markham [:gerv]]

https://github.com/mozilla-b2g/codeaurora_kernel_msm/tree/master/drivers/net/wireless/bcmdhd contains code marked as the proprietary property of Broadcom. As per discussion with mwu in bug 1105380, we should kill this branch (i.e. make sure this code doesn't appear in our repos).

Gerv

Comment 1

[Gervase Markham [:gerv]]

mwu: any idea when you will be able to get to this?

Gerv

Comment 2

[Geoff Piper]

Michael, following up where are we with this?

Comment 3

[Michael Wu [:mwu]]

Attachment: Stop using the master branch on codeaurora_kernel_msm

Not sure who really knows these old manifests anymore, but I guess it doesn't matter much anyway. I think these three manifests are the only ones left using master on codeaurora_kernel_msm. Once we get rid of all users, we can kill that branch.

Comment 4

[:gerard-majax]

Looks good to me, I'm just checking with the few people still using unagi/otoro to make sure it still works for their usecase.

Comment 5

[:gerard-majax]

I just got confirmation that this will break building for otoro devices.

Comment 6

[:gerard-majax]

Comment on attachment 8575652 [details] [review]
Stop using the master branch on codeaurora_kernel_msm

Unago/Otoro builds will fail with:
> Adreno driver not found. Please download the Adreno 2xx User-mode Android ICS Graphics Driver (ARMv7) driver from

But since we don't care a lot anymore ...

Comment 7

[Michael Wu [:mwu]]

That's not bustage from this patch though. Otoro devices always needed a separate gfx driver zip placed in the B2G directory. You can find a copy from the intranet page for Otoro.

Comment 8

[Michael Wu [:mwu]]

https://github.com/mozilla-b2g/b2g-manifest/commit/74c4bdfee6efb94d624f33f7dd8113673f465beb

Comment 9

[Michael Wu [:mwu]]

Master branch deleted.

Comment 10

[Michael Wu [:mwu]]

Bajaj, do you mind if I land this change on all applicable branches? This only affects obsolete devices (otoro) or devices that were only for experimentation (optimus L5, wasabi). We need to land this to fully remove code that we can't distribute.

Comment 11

[bhavana bajaj [:bajaj]]

(In reply to Michael Wu [:mwu] from comment #10)
> Bajaj, do you mind if I land this change on all applicable branches? This
> only affects obsolete devices (otoro) or devices that were only for
> experimentation (optimus L5, wasabi). We need to land this to fully remove
> code that we can't distribute.

:mwu, all in for this change, please land with a=bajaj on applicable branches.

Comment 12

[Michael Wu [:mwu]]

It looks like the removal of the master branch didn't reflect in our mirror - http://git.mozilla.org/?p=b2g/codeaurora_kernel_msm.git;a=summary , so I'll file a separate bug to trim out other branches once we're done with the upstream.

Comment 13

[Michael Wu [:mwu]]

Manifest changes landed:

v1.0.0 https://github.com/mozilla-b2g/b2g-manifest/commit/c9cb27b5638fbbcedef1dd1a57bae384c224dcef
v1.0.1 https://github.com/mozilla-b2g/b2g-manifest/commit/68f2da87fbbc98991c4ec16b6efd739a64b8583d
v1-train https://github.com/mozilla-b2g/b2g-manifest/commit/58ba83a7e89ee03d102107d77d21cb11a871abfe
v1.1.0hd https://github.com/mozilla-b2g/b2g-manifest/commit/ec654fb356ed8b7e9dd8ad6fa86c524b78fc8464
v1.2 https://github.com/mozilla-b2g/b2g-manifest/commit/859b80368325c219b0fe4b17d08da228b607263d
v1.2f https://github.com/mozilla-b2g/b2g-manifest/commit/5a42023c559a8e4d0f7e2000ec8a25b266718770
v1.3 https://github.com/mozilla-b2g/b2g-manifest/commit/f6c4e9e610958d0aad19a72186b330c434404b8c
v1.3t https://github.com/mozilla-b2g/b2g-manifest/commit/feea8f9b59b3416141a45823eec8365f6be7def1
v1.4 https://github.com/mozilla-b2g/b2g-manifest/commit/5124f7123ecb541355deb5f6c5bf31e65a1e2bd8
v2.0 https://github.com/mozilla-b2g/b2g-manifest/commit/4e2e8daeb031bfec69f8b457e63a807af326221e
v2.1 https://github.com/mozilla-b2g/b2g-manifest/commit/415092a9167cd7c8558040797ffec6e206ce12ae
v2.1s https://github.com/mozilla-b2g/b2g-manifest/commit/c716fe8fd3b6c1a2728e39369965eff4ce19e65a
v2.2 https://github.com/mozilla-b2g/b2g-manifest/commit/da20296ddd7cd7d9a618f42009a6a3c4466a0e84

Comment 14

[Michael Wu [:mwu]]

Deleted all version branches of master.

 - [deleted]         v1.0.0
 - [deleted]         v1.0.1
 - [deleted]         v1-train
 - [deleted]         v1.2
 - [deleted]         v1.2f
 - [deleted]         v1.3
 - [deleted]         v1.3t
 - [deleted]         v1.4
 - [deleted]         v2.0
 - [deleted]         v2.1
 - [deleted]         v2.1s
 - [deleted]         v2.2

Comment 15

[Michael Wu [:mwu]]

I think I've done everything I can do on my side. Follow up is necessary in bug 1143982 to remove these branches in our git mirror - http://git.mozilla.org/?p=b2g/codeaurora_kernel_msm.git;a=summary .