1127819 - Ensure that returned element classes for chrome elements is DOMElement and not HTMLElement

Status: RESOLVED WONTFIX

(Testing :: Firefox UI Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Right now all the elements we work with are of type HTMLElement, because they are returned that way by Marionette. Sadly we cannot make use of this class because we need several enhancements added. Therefore the DOMElement class in the puppeteer package exists: 

https://github.com/mozilla/firefox-ui-tests/blob/master/firefox_puppeteer/__init__.py#L76

So what is the best way that methods like find_element() and others would return DOMElement instead?

Chris, what would your proposal be?

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Looking at the implementation of DOMElement, I don't know how much we're getting out of it (although it saves us the inaccuracy of working with XUL and passing around things called "HTMLElement").

I think "calling super" on the inner HTMLElement instance might solve this particular problem (in DOMElement):

def find_element(self, strategy, target):
    el = self.inner.find_element(strategy, target)
    return DOMElement(el)

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Is there a way to subclass from the marionette client, and make it so that when we are in chrome scope DOMElement instances are getting returned when calling methods like find_element? So that would be totally transparent to the tests then.

Comment 3

[Chris Manchester (limited bugmail, email directly)]

(In reply to Henrik Skupin (:whimboo) from comment #2)
> Is there a way to subclass from the marionette client, and make it so that
> when we are in chrome scope DOMElement instances are getting returned when
> calling methods like find_element? So that would be totally transparent to
> the tests then.

I'd recommend against subclassing marionette, but we could expose something like Puppeteer.find_element() that makes this transparent. I don't really see that this solves a fundamental problem for us right now, we can use Marionette.find_element and create DOMElements from that as needed without too much hassle.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

We will leave the classes as supported by Marionette. Also because we want to merge the Firefox ui tests with basic Marionette tests.