Wedged content process with async plugin init

RESOLVED FIXED in Firefox 38

Status

()

Core
Plug-ins
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jimm, Assigned: aklotz)

Tracking

Trunk
mozilla38
x86_64
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox38 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

3 years ago
Created attachment 8557135 [details]
stacks.txt

See attached stacks. I had just closed a tab when this showed up.
(Reporter)

Comment 1

3 years ago
note, chrome was still responsive (the thread's in sitting in WinUtils::WaitForMessage).
Blocks: 1116806
Assignee: nobody → aklotz
Status: NEW → ASSIGNED
Created attachment 8566381 [details] [diff] [review]
Patch (r1)

This patch takes care of a few issues that could cause WaitForInit() to get stuck indefinitely.

SetupBridge could result in a hang if we reused an existing PluginModuleChromeParent, since we would end up waiting for NP_Initialize to happen when it never would (as it is not executed in this case).

WaitForInit was modified to check for conditions that would require us to break out if a failure condition occurred while processing IPC events.

Finally the code for handling errors in streams was cleaned up to ensure that failures are better handled.
Attachment #8566381 - Flags: review?(jmathies)
(Reporter)

Comment 3

3 years ago
Comment on attachment 8566381 [details] [diff] [review]
Patch (r1)

Review of attachment 8566381 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/plugins/ipc/PluginAsyncSurrogate.cpp
@@ +450,5 @@
>      dom::ContentChild* cp = dom::ContentChild::GetSingleton();
>      mozilla::ipc::MessageChannel* contentChannel = cp->GetIPCChannel();
>      MOZ_ASSERT(contentChannel);
>      while (!mParent->mNPInitialized) {
> +      if (mParent->mShutdown) {

nit - add a comment here and below explaining the early return / failure.
Attachment #8566381 - Flags: review?(jmathies) → review+
Blocks: 1129174
Created attachment 8567612 [details] [diff] [review]
Patch (r2)

Added comments. Carrying forward r+.
Attachment #8566381 - Attachment is obsolete: true
Attachment #8567612 - Flags: review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/92279670ec95
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8759f17a42e
Stupid bustage fix:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c07df64140ae
https://hg.mozilla.org/mozilla-central/rev/92279670ec95
https://hg.mozilla.org/mozilla-central/rev/c07df64140ae
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox38: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.