Bug 1127899 (SQLite3.8.8.2)

Upgrade to SQLite 3.8.8.2

RESOLVED FIXED in mozilla38

Status

()

Toolkit
Storage
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Ben Turner (not reading bugmail, use the needinfo flag!), Assigned: Ben Turner (not reading bugmail, use the needinfo flag!))

Tracking

unspecified
mozilla38
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

+++ This bug was initially created as a clone of Bug #1122717 +++

This version only includes one change:

- Enhance sqlite3_wal_checkpoint_v2(TRUNCATE) interface so that it truncates the WAL file even if there is no checkpoint work to be done.

I need this for some IndexedDB work I'm doing.
Created attachment 8557146 [details] [diff] [review]
Patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=983fb38c9ba3
Assignee: nobody → bent.mozilla
Status: NEW → ASSIGNED
Attachment #8557146 - Flags: review?(mak77)

Updated

3 years ago
Alias: SQLite3.8.8.2
Depends on: 1122717
Comment on attachment 8557146 [details] [diff] [review]
Patch

Review of attachment 8557146 [details] [diff] [review]:
-----------------------------------------------------------------

::: db/sqlite3/README.MOZILLA
@@ +1,1 @@
> +This is SQLite 3.8.8.2

what about we finally change this to:

This is the Sqlite amalgamation.
Check sqlite3.h for the version number and source id.

So we can stop editing this file for each version
Attachment #8557146 - Flags: review?(mak77) → review+
https://hg.mozilla.org/mozilla-central/rev/b40b4a20e62c
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38

Comment 6

3 years ago
SQLite 3.8.8.3 has been released.
> Fix a bug (ticket 2326c258d02ead33) that can lead to incorrect results if the qualifying constraint of a partial index appears in the ON clause of a LEFT JOIN. 

Not sure if that warrants us bothering with an update. Mak?
Flags: needinfo?(mak77)
(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #7)
> > Fix a bug (ticket 2326c258d02ead33) that can lead to incorrect results if the qualifying constraint of a partial index appears in the ON clause of a LEFT JOIN. 
> 
> Not sure if that warrants us bothering with an update. Mak?

I think we'll skip for now. The bogus case is limited, and they say it also affects older versions (SQLite 3.8.0 and later), so we would have already noticed issues.
Flags: needinfo?(mak77)

Updated

3 years ago
Blocks: 1136783
No longer blocks: 1136783

Updated

3 years ago
Blocks: 1152939
You need to log in before you can comment on or make changes to this bug.