processor needs to pass --symbols-cache and --symbols-url to stackwalker

RESOLVED FIXED

Status

Socorro
Backend
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: rhelmer, Assigned: lars)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

4 years ago
stackwalker is now able to download and store symbols from HTTP, processor needs to be able to pass these along.
(Reporter)

Updated

4 years ago
Summary: processor needs to path --symbols-cache and --symbols-url to stackwalker → processor needs to pass --symbols-cache and --symbols-url to stackwalker
(Reporter)

Updated

4 years ago
Blocks: 1097216
(Assignee)

Comment 1

4 years ago
is "--symbol-cache" a boolean or is there a value of some type associated with it?
(Assignee)

Comment 2

4 years ago
and is there a docstring that i ought to associate with "--symbol_cache".

how does "--symbol_cache" differ from "--symbol_cache_path" that already exists?
(Reporter)

Comment 3

4 years ago
(In reply to K Lars Lohn [:lars] [:klohn] from comment #1)
> is "--symbol-cache" a boolean or is there a value of some type associated
> with it?

(In reply to K Lars Lohn [:lars] [:klohn] from comment #2)
> and is there a docstring that i ought to associate with "--symbol_cache".
> 
> how does "--symbol_cache" differ from "--symbol_cache_path" that already
> exists?

From "stackwalker --help":

	--symbols-url	A base URL from which URLs to symbol files can be constructed
	--symbols-cache	A directory in which downloaded symbols can be stored
(Reporter)

Comment 4

4 years ago
PR: https://github.com/mozilla/socorro/pull/2614
Assignee: nobody → lars
Status: NEW → ASSIGNED

Comment 5

4 years ago
Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/189d4dcf3a3b3c9b02005f4e3feff78dfd0d4d90
fix bug 981079 and 1127924 - support stackwalker HTTP symbol fetch and caching

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Reporter)

Comment 6

4 years ago
A detail I neglected to mention before is that stackwalker can accept multiple --symbols-url options, which we need to use since we have separate public/private buckets. I went ahead and implemented this in the feature that landed, with explicit --private_symbol_url and --public_symbol_url options (it's fine to leave one unspecified)
You need to log in before you can comment on or make changes to this bug.