Closed Bug 1127928 Opened 10 years ago Closed 10 years ago

Insufficient timeout used when pushing xpcshell tests to Android device (adb, no zip)

Categories

(Testing :: XPCShell Harness, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla38

People

(Reporter: gbrown, Assigned: gbrown)

References

Details

Attachments

(1 file)

Pushing the xpcshell test directory to the test device is one of the longest-running of all remote operations for Android tests -- nearly 5000 files are routinely pushed to device with one call to devicemanager.pushDir(). We use the default timeout of 300 seconds for this pushDir() call. Using devicemanagerSUT for existing tests, 300 seconds appears to be sufficient. But for Android 4.4, we may want to use devicemanagerADB to push to an emulator running on aws; in this environment, the push routinely takes 300 - 400 seconds, often timing out. (Using zip/unzip for the pushDir reduces the push time significantly, but zip/unzip may not be available in all environments.)
Summary: Insufficient timeout used when pushing xpcshell tests to Android device → Insufficient timeout used when pushing xpcshell tests to Android device (adb, no zip)
This increases the timeout for pushing the xpcshell tests directory to 600 seconds (vs the default of 300 seconds). pushDir already took a timeout parameter, but made poor use of it, so I have fixed that too, notably passing the timeout to _checkCmd("push") -- where it is really needed. This eliminates missing-file test failures in my experimental Android 4.4 emulator tests: https://treeherder.mozilla.org/#/jobs?repo=try&revision=17ee50d80793 (there are still other failures which look unrelated).
Attachment #8557247 - Flags: review?(wlachance)
Comment on attachment 8557247 [details] [diff] [review] increase pushDir(xpcshell tests) timeout to 600 seconds Review of attachment 8557247 [details] [diff] [review]: ----------------------------------------------------------------- Reasonable! ::: testing/xpcshell/remotexpcshelltests.py @@ +454,5 @@ > > def setupTestDir(self): > print 'pushing %s' % self.xpcDir > try: > + self.device.pushDir(self.xpcDir, self.remoteScriptsDir, timeout=600, retryLimit=10) Could you put a comment in about why this is so long?
Attachment #8557247 - Flags: review?(wlachance) → review+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: