1127945 - 500 error when trying to publish review after discarding a previous draft

Status: RESOLVED INVALID

(MozReview Graveyard :: General, defect, P3)

Description

[Andrew Halberstadt [:ahal]]

I'm not %100 sure these are the exact STR:

1) Make second commit on existing review, and push it
2) Discard the draft
3) Ammend changeset, push to review again

Results:
* 500 Internal Server error when trying to publish
* bugzilla flag flipped to r?
* request still in unpublished state and new commit does not appear in the UI

Comment 1

[Andrew Halberstadt [:ahal]]

Of potential note, I'm using mercurial 3.3-rc.

Comment 2

[Andrew Halberstadt [:ahal]]

Would probably also help to link the review in question..

https://reviewboard.mozilla.org/r/2741

Comment 3

[Gregory Szorc [:gps]]

2015-01-30 18:25:15,208 - ERROR -  - Exception thrown for user ahal at https://reviewboard.mozilla.org/api/review-requests/2741/draft/

3 (<type 'unicode'>) and 4 (<type 'int'>) are of two different value types.
Traceback (most recent call last):
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/Django-1.6.10-py2.6.egg/django/core/handlers/base.py", line 112, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/Django-1.6.10-py2.6.egg/django/views/decorators/cache.py", line 52, in _wrapped_view_func
    response = view_func(request, *args, **kwargs)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/Django-1.6.10-py2.6.egg/django/views/decorators/vary.py", line 19, in inner_func
    response = func(*args, **kwargs)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/Djblets-0.8.14-py2.6.egg/djblets/webapi/resources.py", line 496, in __call__
    request, method, view, api_format=api_format, *args, **kwargs)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/Djblets-0.8.14-py2.6.egg/djblets/webapi/resources.py", line 567, in call_method_view
    return view(request, *args, **kwargs)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/Djblets-0.8.14-py2.6.egg/djblets/webapi/resources.py", line 764, in put
    return self.update(request, *args, **kwargs)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/Djblets-0.8.14-py2.6.egg/djblets/webapi/decorators.py", line 117, in _call
    return view_func(*args, **kwargs)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/ReviewBoard-2.0.12-py2.6.egg/reviewboard/webapi/decorators.py", line 110, in _check
    return view_func(*args, **kwargs)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/Djblets-0.8.14-py2.6.egg/djblets/webapi/decorators.py", line 117, in _call
    return view_func(*args, **kwargs)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/Djblets-0.8.14-py2.6.egg/djblets/webapi/decorators.py", line 138, in _checklogin
    return view_func(*args, **kwargs)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/Djblets-0.8.14-py2.6.egg/djblets/webapi/decorators.py", line 117, in _call
    return view_func(*args, **kwargs)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/Djblets-0.8.14-py2.6.egg/djblets/webapi/decorators.py", line 117, in _call
    return view_func(*args, **kwargs)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/Djblets-0.8.14-py2.6.egg/djblets/webapi/decorators.py", line 287, in _validate
    return view_func(*args, **new_kwargs)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/ReviewBoard-2.0.12-py2.6.egg/reviewboard/webapi/resources/review_request_draft.py", line 481, in update
    review_request.publish(user=request.user)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/ReviewBoard-2.0.12-py2.6.egg/reviewboard/reviews/models/review_request.py", line 778, in publish
    changes = draft.publish(self, send_notification=False)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/ReviewBoard-2.0.12-py2.6.egg/reviewboard/reviews/models/review_request_draft.py", line 244, in publish
    old_value, new_value)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/ReviewBoard-2.0.12-py2.6.egg/reviewboard/reviews/fields.py", line 149, in record_change_entry
    changedesc.record_field_change(self.field_id, old_value, new_value)
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/ReviewBoard-2.0.12-py2.6.egg/reviewboard/changedescs/models.py", line 76, in record_field_change
    new_value, type(new_value)))
ValueError: 3 (<type 'unicode'>) and 4 (<type 'int'>) are of two different value types.

Comment 4

[Mark Côté [:mcote]]

We have too many P1s, so I'm spreading out the priorities.  P3 -> P4, P2 -> P3, and some portion of P1s will become P2.

Comment 5

[BMO Automation]

MozReview is now obsolete. Please use Phabricator instead. Closing this bug.