1128092 - Use notifications with dynamic height for finishing pending Sync upgrade, too long/cropped in many locales

Status: RESOLVED INVALID

(Firefox :: Sync, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Firefox for Android, Aurora branch 20150130 (API 11 build), Android 4.1.2 on Nexus S (stock image)

Having a Firefox Sync 1.1 account on the device which gets migrated to 1.5 (Firefox accounts based) on a different device will show a notification to finish the upgrading of Sync on the Android device. The header and content of that notification gets cropped in many languages (e.g. German / "Deutsch") because the texts are too long. Please use such notifications which set the appropriate height, don't remember the name, but iirc supported since Android 4.0 and used by the data reporting notification.

Comment 1

[Nick Alexander :nalexander [he/him]]

Thanks for the report.  This is a great mentor ticket.

What needs to happen: at [1], we use the [2] NotificationCompat.Builder to make a notification.  We should try to use the BigTextStyle notification as well [3].  (We'll need to test against a pre-4.1 device to make sure we don't break things here.)  Hopefully we can use our existing messages with a big text notification.

See http://stackoverflow.com/a/13721315 and the link for more information.

[1] https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/fxa/sync/FxAccountNotificationManager.java#103

[2] http://developer.android.com/reference/android/support/v4/app/NotificationCompat.Builder.html

[3] http://developer.android.com/reference/android/support/v4/app/NotificationCompat.BigTextStyle.html

Comment 2

[Nick Alexander :nalexander [he/him]]

In case it's not clear, we should do this for *all* Firefox Account notifications, not just the migration ones.

Comment 3

[vaibhav [:vaibhavChoudhary]]

nick,i would like to work on this bug.

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Hi vaibhav,
thank you for working on this bug. The notification got added in bug 1098667, the texts are at
https://hg.mozilla.org/mozilla-central/rev/ae7ca57ce760#l14.55
and get used at
https://hg.mozilla.org/mozilla-central/rev/ae7ca57ce760#l12.32

The code for data reporting notification which uses the new style can be found at http://hg.mozilla.org/mozilla-central/rev/5b345b6dc928#l2.63

Documentation how to build Firefox for Android, about the developer style and debugging tips can be found at https://wiki.mozilla.org/Mobile/Fennec/Android

If you have further questions or get stuck, please ask.

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: sync-migration-testing-latest.html

You can find the instructions to get the Sync upgrade dialog in this file or by visiting https://id.etherpad.mozilla.org/sync-migration-testing

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

vaibhav, are you working on this bug? If yes, do you need more information?

Comment 7

[Nick Alexander :nalexander [he/him]]

This ticket is no longer relevant, since we've removed the Old Sync code (and migration path) in Bug 1220906.