Closed Bug 1128097 Opened 9 years ago Closed 9 years ago

Unable to compile js 32-bit ARM-simulator shells on Mac

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
blocker

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox38 --- affected

People

(Reporter: gkw, Assigned: gkw)

Details

(Keywords: regression, Whiteboard: [fuzzblocker])

Attachments

(2 files)

Attached file stack
I hit a compile failure when compiling js 32-bit ARM-simulator shell on m-c rev d7e156a7a0a6.

LD=ld CROSS_COMPILE=1 CC="clang -Qunused-arguments -msse2 -mfpmath=sse -arch i386" RANLIB=ranlib CXX="clang++ -Qunused-arguments -msse2 -mfpmath=sse -arch i386" AS=$CC AR=ar STRIP="strip -x -S" HOST_CC="clang -Qunused-arguments -msse2 -mfpmath=sse" AUTOCONF=/usr/local/Cellar/autoconf213/2.13/bin/autoconf213 HOST_CXX="clang++ -Qunused-arguments -msse2 -mfpmath=sse" sh /Users/skywalker/trees/mozilla-central/js/src/configure --target=i386-apple-darwin9.2.0 --enable-macos-target=10.5 --enable-arm-simulator --enable-debug --enable-optimize --enable-nspr-build --enable-more-deterministic --with-ccache --enable-gczeal --enable-debug-symbols --disable-tests

===

autoBisect shows this is probably related to the following changeset:

The first bad revision is:
changeset:   https://hg.mozilla.org/mozilla-central/rev/b0e9b9113cb0
user:        Lars T Hansen
date:        Fri Jan 30 09:15:16 2015 +0100
summary:     Bug 1125837 - smush SimulatorRuntime into Simulator.  r=jandem

Lars, is bug 1125837 a likely regressor? This blocks fuzzing 32-bit ARM simulator builds on Mac.
Flags: needinfo?(lhansen)
Attached patch patch v1Splinter Review
Credits to Jan for suggesting how to fix this.

rs=jandem over IRC, and I've checked that this does fix the broken Mac 32-bit ARM-simulator build.
Assignee: nobody → gary
Status: NEW → ASSIGNED
Flags: needinfo?(lhansen)
Attachment #8557382 - Flags: review+
Funny, I compiled with Clang locally, but it didn't catch that problem.  I guess Clang on Linux is not like Clang on Mac.
https://hg.mozilla.org/mozilla-central/rev/ce52eb68bc21
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: