1128108 - Assertion failure: owner->isEnabled(), at gc/StoreBuffer.cpp

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

verifypostbarriers();

asserts js debug shell on m-c changeset d7e156a7a0a6 with --fuzzing-safe --no-threads --no-ion --no-ggc at Assertion failure: owner->isEnabled(), at gc/StoreBuffer.cpp.

Debug configure options:

CC="clang -Qunused-arguments" CXX="clang++ -Qunused-arguments" AR=ar AUTOCONF=/usr/local/Cellar/autoconf213/2.13/bin/autoconf213 sh /Users/skywalker/trees/mozilla-central/js/src/configure --target=x86_64-apple-darwin12.5.0 --enable-debug --enable-optimize --enable-nspr-build --enable-more-deterministic --with-ccache --enable-gczeal --enable-debug-symbols --disable-tests

(Guessing that this has been happening since bug 706885, which landed --no-ggc, so has been around for quite a while.)

Terrence, any idea what's going on here? (fwiw I only just recently implemented --no-ggc support)

Comment 1

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: stack

Comment 2

[Christian Holler (:decoder)]

JSBugMon: Cannot process bug: Unable to automatically reproduce, please track manually.

Comment 3

[Terrence Cole [:terrence]]

Attachment: noggc-verifypostbarriers-v0.diff

I think we shouldn't allow barrier verification to start when ggc is already disabled.

Comment 4

[Jon Coppeard (:jonco)]

Comment on attachment 8558071 [details] [diff] [review]
noggc-verifypostbarriers-v0.diff

Review of attachment 8558071 [details] [diff] [review]:
-----------------------------------------------------------------

That makes sense.

Comment 5

[Terrence Cole [:terrence]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f33e104ef0b4

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f33e104ef0b4