112817 - DOM Inspector should scroll to the right element in the browser pane

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, enhancement)

Description

[Itamar]

When clicking on elements in the DOM nodes pane the refered element flashes in
red in the browser pane.
I think it would be nice that if the selected element in the browser pane is not
visible, then the Inspector will scroll the browser window to the element first
and only then flash.

Comment 1

[Boris Zbarsky [:bzbarsky]]

definitely. 

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: proposed patch

Comment 3

[Boris Zbarsky [:bzbarsky]]

Fabian, would you review?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Better patch.

Looks like only HTML elements have scrollIntoView....

Put in a check for existence before calling the function, but we may want to
come up with a different mechanism for a random XUL document....

Comment 5

[Fabian Guisset]

Comment on attachment 59865 [details] [diff] [review]
Better patch.

r=fabian

Comment 6

[Joe Hewitt (gone)]

Comment on attachment 59865 [details] [diff] [review]
Better patch.

sr=hewitt

Comment 7

[Boris Zbarsky [:bzbarsky]]

checked in

Comment 8

[rbs]

Unfortunately, the whole world of XML/XHTML/MathML is left out of the equation.
What about another iteration/bug to get a more comprehensive way (using the 
selection controller -- c.f. example of use in bug 122524 - attachment 82672 [details] [diff] [review]). 
Cc:me in the loop if you intent to pursue it.

Comment 9

[Boris Zbarsky [:bzbarsky]]

File a bug on me?  I'll look at it at some point....

Comment 10

[rbs]

It is not critical. Just one of those enhancements that make the difference.

Comment 11

[rbs]

-> bug 163137 is the follow-up for the non-HTML case.