1128222 - Save Image As... should save image as (doh)

Status: RESOLVED DUPLICATE of bug 120809

(Firefox :: File Handling, defect)

Description

[Jacek Trzmiel]

User Agent: Mozilla/5.0 (Windows NT 5.2; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0
Build ID: 20141126041045

Steps to reproduce:

1. Open https://upload.wikimedia.org/wikipedia/commons/c/c9/Tamme-Lauri_tamm_suvep%C3%A4eval.jpg
2. Wait for image to download.
3. Right click on it and 'Save Image As...'


Actual results:

Image gets redownloaded and then saved to disk (and sometimes it fails, because of network problems, etc.).  Failure is completely silent, which is utterly unacceptable, i.e. you never know if it saved correctly or not, unless you go to the folder and check if it's complete or not.


Expected results:

Already downloaded and displayed image should be saved as-is.  No network connection required, no nothing, no excuses accepted.  If it's displayed, just save it to disk and be done with it.  Cache limits be dammed.  Consistent user experience is critical.  In worst case, if you can't really save image as, for any reason, don't give this option, give 'Redownload Image As...' option instead - be honest about it.

Comment 1

[Matthias Versen [:Matti]]

>Already downloaded and displayed image should be saved as-is
Firefox can't not restore the original file from the displayed data.

>(and sometimes it fails, because of network problems, etc.)
We had a check in place that compares downloaded size vs the reported size of the http content-length header.
Unfortunately too many servers were broken and we had to remove the check again for http/1 servers and it will only be checked for http/2 servers.

Anyway, i followed your example and i can not reproduce the redownlaod. The file cache was used as expected (I checked the http headers first).

Comment 2

[Manojit Ballav]

When i followed the steps to regenerate it, It worked like it should.
I let the image to download then i right clicked on the image and selected "Save image as" and downloaded
the download didn't fail and all the 21 MB of the image was downloaded. It took some time but the download completed.
Then again i clicked on the image and repeated the above step and the already downloaded image was shown.
Which is actually what it should. No this works fine.

Comment 3

[Gingerbread Man]

(In reply to Jacek Trzmiel from comment #0)
> Actual results:
> 
> Image gets redownloaded and then saved to disk (and sometimes it fails,
> because of network problems, etc.).  Failure is completely silent, which is
> utterly unacceptable, i.e. you never know if it saved correctly or not,
> unless you go to the folder and check if it's complete or not.

Please don't conflate multiple issues into one report. The above is probably bug 237623.

> Expected results:
> 
> Already downloaded and displayed image should be saved as-is.  No network
> connection required…

Marking as a duplicate based on the above.