TEST-UNEXPECTED-FAIL | xpcshell-icaljs.ini:calendar/test/unit/test_alarmservice.js | test_addItems - [test_addItems : 12] false == true

RESOLVED FIXED in 4.0.0.1

Status

Calendar
Internal Components
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Fallen, Assigned: darktrojan)

Tracking

Trunk
4.0.0.1

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
I believe this may be a regression from the timezone service changes. Geoff, can you take a look?
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Reporter)

Comment 5

2 years ago
Try run with bug 1095119 backed out, to rule it out as a suspect.

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=608c2b7ae919
(Reporter)

Comment 6

2 years ago
Oh actually, this is probably bug 1128070 which you are already working on. Sorry about that, I was too quick on filing the bug.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1128070
(Assignee)

Comment 7

2 years ago
I don't think what I'm working on there would fix this. Not sure why it's only showing up sometimes, although it does involve asynchronous code.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
(Assignee)

Comment 8

2 years ago
Created attachment 8557655 [details] [diff] [review]
1128293-1.diff

This ensures the timezone service is ready before running the test. Also removed some needless QI'ing I added in some other tests nearby.
Attachment #8557655 - Flags: review?(philipp)
(Reporter)

Comment 9

2 years ago
Comment on attachment 8557655 [details] [diff] [review]
1128293-1.diff

Review of attachment 8557655 [details] [diff] [review]:
-----------------------------------------------------------------

r=philipp
Attachment #8557655 - Flags: review?(philipp) → review+
(Reporter)

Comment 10

2 years ago
I believe you pushed this as https://hg.mozilla.org/comm-central/rev/f0194350ebf3

Unfortunately there is still a bustage. If its the same issue but for a different test again, maybe we should figure out if there is a way to lazy-init the timezone service without breaking synchronous functions. If that doesn't work, then I should upload my patch for adding a do_init_calendar() function that does the full startup service initialization.
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Comment 17

2 years ago
This is something different. Something's causing a crash (!), and in test_datetime.js we've already ensured the timezone service is ready. Hmmm...
(Assignee)

Comment 18

2 years ago
I'm going to call this fixed and deal with the crashing in bug 1128731.
Status: REOPENED → RESOLVED
Last Resolved: 2 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.0
You need to log in before you can comment on or make changes to this bug.