Closed Bug 1128363 Opened 9 years ago Closed 9 years ago

Table versioning should be per-table

Categories

(Firefox for iOS :: Data Storage, defect)

All
iOS 8
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: wesj, Assigned: wesj)

References

Details

Attachments

(1 file, 1 obsolete file)

47 bytes, text/x-github-pull-request
rnewman
: review+
Details | Review
In the new table implementation, the database doesn't hold onto references to its tables. Instead, they're injected dynamically when needed. That means that we can't do a generic upgrade/downgrade of the entire table at once.

As a way around this, I'd like to just maintain a separate database of tables and versions. When a new HistoryTable is created (for instance) it will be responsible for calling db.create(HistoryTable) and handling the upgrade/creation there.
Attached file Pull request (obsolete) —
Attachment #8557682 - Flags: review?(rnewman)
Attached file Pull request
I updated the PR with some of your comments. Thanks nick!
Attachment #8557682 - Attachment is obsolete: true
Attachment #8557682 - Flags: review?(rnewman)
Attachment #8560770 - Flags: review?(nalexander)
Assignee: nobody → wjohnston
Blocks: 1126992, 1126993
Status: NEW → ASSIGNED
OS: Mac OS X → iOS 8
Hardware: x86 → All
Attachment #8560770 - Flags: review?(nalexander) → review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: