Largest icon size is wrong in manifest: it does not fit the real icon size

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: oteo, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [loop approved for 1.1.1][In 1.1.1])

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
The largest icon is 168px and the manifest says it is 187px. We should change the manifest to show the real icon size:

"168": "/style/images/icons/Icon_Hello@2.png"
Comment on attachment 8557701 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/firefoxos-loop-client/pull/543

perfect, you're right
Attachment #8557701 - Flags: review?(crdlc) → review+
in master:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/3f241637fca2d9bc379d52ab75a2fe14c0bd4afb
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Reporter)

Updated

4 years ago
Whiteboard: [loop approved for 1.1.1]
(Reporter)

Updated

4 years ago
Blocks: 1097495
Whiteboard: [loop approved for 1.1.1] → [loop approved for 1.1.1][In 1.1.1]
You need to log in before you can comment on or make changes to this bug.