Closed
Bug 1128384
Opened 9 years ago
Closed 9 years ago
[Stingray][demo] fling only supports string format message and shouldn't use addEventListener
Categories
(Firefox OS Graveyard :: Gaia::TV, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: johnhu, Assigned: johnhu)
References
Details
(Whiteboard: [partner-cherry-picked <2015/11/2>])
Attachments
(1 file)
fling sender/player uses JavaScript object as message. This is wrong. We only supports string. The other issue is that we only support onmessage instead of addEventListener('message'...)
|
Assignee | |
Comment 1•9 years ago
|
||
Rex, Please review this patch.
Attachment #8557714 -
Flags: review?(rexboy)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8557714 [details] [review] use string as message and use onmessage Looks good to me.
Attachment #8557714 -
Flags: review?(rexboy) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
merged to master: https://github.com/mozilla-b2g/gaia/commit/a75a12c5aaaa849f0e7de4b85fa6e713e0a9fa82 gaia try is almost all green with two known intermittent error: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=c1ff2f14ab82
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
||
Updated•9 years ago
|
Whiteboard: [partner-cherry-pick]
|
||
Updated•9 years ago
|
Whiteboard: [partner-cherry-pick] → [picked <2015/11/2>]
|
|
||
Updated•9 years ago
|
Whiteboard: [picked <2015/11/2>] → [partner-cherry-picked <2015/11/2>]
You need to log in
before you can comment on or make changes to this bug.
Description
•