1128389 - [EME] rename "keyschange" to "keystatuseschange"

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

Per spec change in https://github.com/w3c/encrypted-media/commit/9f11418745e73fcd5f5dfdfe14608d84a73f3b42.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1128389_rename_keyschange_to_keystatuseschange-v1.patch

Hi bz,
Can you review nsGkAtomList.h? Thanks. Is there something else to be changed when renaming the event name from "keyschange" to "keystatuseschange"?

Hi Chris,
Can you reivew other naming changes in gmp/eme/test files? Thanks.

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

try: https://tbpl.mozilla.org/?tree=Try&rev=a40036251f10

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8557724 [details] [diff] [review]
1128389_rename_keyschange_to_keystatuseschange-v1.patch

Review of attachment 8557724 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8557724 [details] [diff] [review]
1128389_rename_keyschange_to_keystatuseschange-v1.patch

The atom list change looks fine.  It's just an optimization anyway, since I don't think anyone uses nsGkAtoms::keyschange anywhere.

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Try is green: https://tbpl.mozilla.org/?tree=Try&rev=77c8f23cfee2

Comment 6

[Carsten Book [:Tomcat]]

Hi Jw, this patch failed to apply: 

applying 1128389_rename_keyschange_to_keystatuseschange-v1.patch
patching file dom/base/nsGkAtomList.h
Hunk #1 FAILED at 491
1 out of 1 hunks FAILED -- saving rejects to file dom/base/nsGkAtomList.h.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh 1128389_rename_keyschange_to_keystatuseschange-v1.patch

could you take a look? Thanks!

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

nsGkAtomList.h needs to rebase. I will try to land the patch when inbound is open.

Comment 8

[JW Wang [:jwwang] [:jw_wang]]

inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8c0775a97331

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8c0775a97331

Comment 10

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/releases/mozilla-beta/rev/336529d8cd1a

Comment 11

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Beta patch

Patch for beta branch as part of EME platform uplift.

Comment 12

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8572344 [details] [diff] [review]
Beta patch

Requesting retroactive approval for Beta landing as part of EME platform uplift.

Comment 13

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8572344 [details] [diff] [review]
Beta patch

Approved for Beta as part of EME platform uplift.