Closed Bug 1128389 Opened 7 years ago Closed 7 years ago

[EME] rename "keyschange" to "keystatuseschange"

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox37 --- fixed
firefox38 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(2 files)

Hi bz,
Can you review nsGkAtomList.h? Thanks. Is there something else to be changed when renaming the event name from "keyschange" to "keystatuseschange"?

Hi Chris,
Can you reivew other naming changes in gmp/eme/test files? Thanks.
Assignee: nobody → jwwang
Status: NEW → ASSIGNED
Attachment #8557724 - Flags: review?(cpearce)
Attachment #8557724 - Flags: review?(bzbarsky)
Comment on attachment 8557724 [details] [diff] [review]
1128389_rename_keyschange_to_keystatuseschange-v1.patch

Review of attachment 8557724 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8557724 - Flags: review?(cpearce) → review+
Comment on attachment 8557724 [details] [diff] [review]
1128389_rename_keyschange_to_keystatuseschange-v1.patch

The atom list change looks fine.  It's just an optimization anyway, since I don't think anyone uses nsGkAtoms::keyschange anywhere.
Attachment #8557724 - Flags: review?(bzbarsky) → review+
Hi Jw, this patch failed to apply: 

applying 1128389_rename_keyschange_to_keystatuseschange-v1.patch
patching file dom/base/nsGkAtomList.h
Hunk #1 FAILED at 491
1 out of 1 hunks FAILED -- saving rejects to file dom/base/nsGkAtomList.h.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh 1128389_rename_keyschange_to_keystatuseschange-v1.patch

could you take a look? Thanks!
Flags: needinfo?(jwwang)
Keywords: checkin-needed
nsGkAtomList.h needs to rebase. I will try to land the patch when inbound is open.
https://hg.mozilla.org/mozilla-central/rev/8c0775a97331
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Attached patch Beta patchSplinter Review
Patch for beta branch as part of EME platform uplift.
Comment on attachment 8572344 [details] [diff] [review]
Beta patch

Requesting retroactive approval for Beta landing as part of EME platform uplift.
Attachment #8572344 - Flags: approval-mozilla-beta?
Comment on attachment 8572344 [details] [diff] [review]
Beta patch

Approved for Beta as part of EME platform uplift.
Attachment #8572344 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.