1128399 - [Bluetooth][Settings] Handle Dom event 'BluetoothAdapter.onaborted' to cancel confirmation while a remote device cancel the pairing request.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[[e-mail], [e-mail]]

STD:
1. Turn Bluetooth on.
2. Set visible on.
3. Use a remote device to pair with FFOS phone.
4. The pairing dialog shows to wait a user confirmation.
5. Cancel the pairing request from remote device.

Expected:
The pairing dialog should be close.

Actual:
The pairing dialog still waits a user confirmation.

Comment 1

[[e-mail], [e-mail]]

Per discussion on Bug 1128383, Gaia will handle the new event 'BluetoothAdapter.onaborted' to cancel the confirmation of incoming pairing request while a remote device has canceled it.

Comment 2

[Ben Tian (inactive)]

Bug 1128383 has landed gecko webidl change [1] and implementation. Note adapter.onpairingaborted would fire as long as pairing fails for one of the reasons: 1) authentication error, 2) pairing cancellation, and 3) other internal errors.

[1] https://dxr.mozilla.org/mozilla-central/source/dom/webidl/BluetoothAdapter2.webidl#57

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] ian-liu:bluetooth/bug1128399_handle_onpairingaborted_event_for_cancel_pairing_process > mozilla-b2g:master

Comment 4

[[e-mail], [e-mail]]

Comment on attachment 8584420 [details] [review]
[gaia] ian-liu:bluetooth/bug1128399_handle_onpairingaborted_event_for_cancel_pairing_process > mozilla-b2g:master

Arthur, 

Since Bug 1128383 is landed for DOM event 'onpairingaborted', we can watch the event and handle it as handling 'bluetooth-cancel' as before. Could you please help to review my pull request? Thanks.

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8584420 [details] [review]
[gaia] ian-liu:bluetooth/bug1128399_handle_onpairingaborted_event_for_cancel_pairing_process > mozilla-b2g:master

r=me with the comment addressed, thanks!

Comment 6

[[e-mail], [e-mail]]

Thanks for Arthur's reviewing effort. Updated the patch and wait try-server test process.

Comment 7

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 8

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/320b7f5c0b81f09cce2a39306a15077db8e9bc7d