1128417 - Incorrect end time for media element when captured

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

In capture mode, 'ended' event is reported in MediaDecoder::DecodedStreamGraphListener::DoNotifyFinished() without waiting for audio/video samples to be fully drained in MediaDecoderStateMachine::RunStateMachine(). We should call UpdatePlaybackPosition() to ensure the end time is consistent with that of non-capture mode.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1128417_fix_end_time_in_capture_mode-v1.patch

Handle playback ended in a consistent way for both file and stream case.

Try most green: https://treeherder.mozilla.org/#/jobs?repo=try&revision=854eae361f01

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/04c1b5a08d9c

Note: bug 1127235, bug 1128417 and bug 901102 must be landed together.

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/04c1b5a08d9c