Open Bug 1128464 Opened 9 years ago Updated 2 years ago

xpcshell tests in toolkit should be independent from firefox

Categories

(Toolkit :: General, defect)

defect

Tracking

()

People

(Reporter: hiro, Unassigned)

References

(Depends on 1 open bug)

Details

There are some xpcshell.ini declaring "firefox-appdir = browser', but in theory it should be removed. So tests in those directory will make robust. e.g. eliminating test failures on comm-central. 

I am going to use this bug as a tracker bug.
Depends on: 1129794
Depends on: 1132772
Depends on: 1136019
(In reply to Hiroyuki Ikezoe (:hiro) from comment #0)
> There are some xpcshell.ini declaring "firefox-appdir = browser', but in
> theory it should be removed.

I'm not sure I understand why this is the case. What does that directive do exactly?
Flags: needinfo?(hiikezoe)
Some tests in toolkit/ were broken on comm-central several times because those tests depended on preference of firefox or search engine for firefox.  Those mistakes are not noticeable if firefox-appdir = browser in xpcshell.ini.
Flags: needinfo?(hiikezoe)
Can you point me to an example of a test failure and its fix?
Bug 1115440 and 1099332.
firefox-appdir was added for Metro in bug 810617 and bug 755724. Looks like it went a little bit too far, it's ok for browser/ and services/ to point to a firefox appdir, but Toolkit should never depend on browser. In an ideal world at least.

Gavin, I'm fine leaving bug 1136019 reviews to you, you have a better insight than me there and maybe want to give that a different direction.
Depends on: 1138274
Depends on: 1141444
Depends on: 1143539
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.