1128483 - Intermittent month_view_test.js | month view should gray out numbers outside current month

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[:gerard-majax]

This test will fail the whole month of february this year: the test checks for any day displayed as gray on the UI, but the month starts on saturday, 1st and ends on sunday 28th. So no gray is expected.

Comment 1

[Julien Wajsberg [:julienw]]

Disabled in a8576395130d18987f51e916a07aff8e0f23e930

That's quite unfortunate that February 2015 has no gray day :)

The fix should be to force a specific month/year and check that the expected days are gray.

Comment 2

[Julien Wajsberg [:julienw]]

Attachment: screenshot of the issue

Comment 3

[GitHub Autolander Bot]

Attachment: [PullReq] gaye:bug-1128483 to mozilla-b2g:master

Comment 4

[Gareth Aye [:gaye] (back from PTO)]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27930/files

Since some Februaries shouldn't have any grey days, swipeLeft on February

Comment 5

[Julien Wajsberg [:julienw]]

Please uplift to branches, thanks :)
(since it's test only, no need for approval)

Comment 6

[Julien Wajsberg [:julienw]]

(add a=npotb)

Comment 7

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=gaia-try&job_id=492814
repository: gaia-try
start_time: 2015-02-05T01:11:55
who: jwajsberg[at]mozilla[dot]com
machine: tst-linux64-spot-818
buildname: b2g_ubuntu64_vm gaia-try opt test gaia-js-integration-1
revision: 71eb254bc449

TEST-UNEXPECTED-FAIL | apps/calendar/test/marionette/month_view_test.js | month view should gray out numbers outside current month
AssertionError: expected false to be true
AssertionError: expected false to be true
make: *** [test-integration-test] Error 1
Return code: 2
Tests exited with return code 2: harness failures
# TBPL FAILURE #

Comment 8

[Gareth Aye [:gaye] (back from PTO)]

Hey Miller I'm on PTO today through next Monday. Would you mind landing this and uplifting? Thanks!!

Comment 9

[Miller Medeiros [:millermedeiros]]

landed on master: https://github.com/mozilla-b2g/gaia/commit/b8622780601a11eb033a24929c8e2a26155f19aa

Comment 10

[Miller Medeiros [:millermedeiros]]

landed on v2.2: https://github.com/mozilla-b2g/gaia/commit/fef87cf70c388e5b5bdbfc5b57ef014aa0698613