1128497 - [Tablet] No scroll bar in portrait mode in Tab Panel

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[u421692]

1. Open lots of tabs(more tabs open than will fit on a single screen)
2. Tap on tab number to open Tab Panel
3. Put tablet in portrait mode and scroll tab thumbnails

Expected result:
Tabs are easily scrolled, and scroll bar is present in the right side of the Tab panel

Actual result:
Scroll bar is not present in the right side of the Tab panel

Note: 
*Scroll bar available in landscape mode.
*I believe that this is not a regression, and was never implemented ok since new tablet UI.
*Needs to be addressed in the new-tablet-v1?

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Curious - any ideas, Martyn?

Comment 2

[Martyn Haigh (:mhaigh)]

Attachment: Bug 1128497 - [Tablet] No scroll bar in portrait mode in Tab Panel

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8561494 [details] [diff] [review]
Bug 1128497 - [Tablet] No scroll bar in portrait mode in Tab Panel

Review of attachment 8561494 [details] [diff] [review]:
-----------------------------------------------------------------

If this works, then it works for me.

However, edification question: how does the style inheritance work here? Does TabsGridLayout inherit both TabsLayout and TabsGridLayout (via R.attr.tabsGridLayoutViewStyle in the constructor)? I would assume TabsLayout is overridden by explicitly defining R.attr.tabsGridLayoutViewStyle, but if this patch works, then I guess not.

Comment 4

[Martyn Haigh (:mhaigh)]

> However, edification question: how does the style inheritance work here?
> Does TabsGridLayout inherit both TabsLayout and TabsGridLayout (via
> R.attr.tabsGridLayoutViewStyle in the constructor)? I would assume
> TabsLayout is overridden by explicitly defining
> R.attr.tabsGridLayoutViewStyle, but if this patch works, then I guess not.

I would assume that TabsGridLayout does inherit both styles (one through the tabs_panel_default.xml / private_tabs_panel.xml file and one through the argument in the constructor that you pointed out) and that these combine, although I don't know off the top of my head which takes priority.

Comment 5

[Martyn Haigh (:mhaigh)]

https://hg.mozilla.org/integration/fx-team/rev/0c61e565d418

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0c61e565d418

Comment 7

[u421692]

Verified as fixed on latest Nightly on Sony Xperia Z2(Android 4.4.4), and Nexus 7(Android 5.0.2)