1128521 - crash in java.lang.NoSuchMethodError: org.mozilla.search.SearchActivity.isDestroyed at org.mozilla.search.SearchActivity$6.onAnimationEnd(SearchActivity.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Search Activity, defect)

Description

[Aaron Train [:aaronmt]]

This bug was filed from the Socorro interface and is 
report bp-55f5fe3a-8d5e-4e1c-bc8f-695992150201.
=============================================================

java.lang.NoSuchMethodError: org.mozilla.search.SearchActivity.isDestroyed
	at org.mozilla.search.SearchActivity$6.onAnimationEnd(SearchActivity.java:344)
	at com.nineoldandroids.animation.AnimatorSet$AnimatorSetListener.onAnimationEnd(AnimatorSet.java:756)
	at com.nineoldandroids.animation.ValueAnimator.endAnimation(ValueAnimator.java:1034)
	at com.nineoldandroids.animation.ValueAnimator.access$900(ValueAnimator.java:43)
	at com.nineoldandroids.animation.ValueAnimator$AnimationHandler.handleMessage(ValueAnimator.java:669)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:153)
	at android.app.ActivityThread.main(ActivityThread.java:5006)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:821)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:584)
	at dalvik.system.NativeStart.main(Native Method)

Comment 1

[:Margaret Leibovic]

Crap.

[Tracking Requested - why for this release]: Regression from bug 1089653.

Comment 2

[:Margaret Leibovic]

Attachment: MozReview Request: bz://1128521/margaret

/r/3289 - Bug 1128521 - Don't use API 17+ method in search activity. r=mfinkle

Pull down this commit:

hg pull review -r 84dcdf3e202095ca403b1aac13ed976953f87ce2

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

https://reviewboard.mozilla.org/r/3289/#review2703

LGTM. If this is still racing with the onDestroy, we could move the searchEngineManager destruction above the super.onDestroy() in an attempt to clear out the state ASAP.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8558687 [details]
MozReview Request: bz://1128521/margaret

https://reviewboard.mozilla.org/r/3287/#review2709

Ship It!

Comment 5

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/cceedc43a9ec

Comment 6

[:Margaret Leibovic]

Comment on attachment 8558687 [details]
MozReview Request: bz://1128521/margaret

Approval Request Comment
[Feature/regressing bug #]: bug 1089653 
[User impact if declined]: search activity will crash on devices running Android < 4.2
[Describe test coverage new/current, TreeHerder]: no automated tests, tested locally
[Risks and why]: adds a null check (same risk profile as bug 1089653, except this time I did the patch correctly!)
[String/UUID change made/needed]: none

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cceedc43a9ec

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/02448988e634
https://hg.mozilla.org/releases/mozilla-beta/rev/9b1ff4e3ca58

Comment 10

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1128521 - Don't use API 17+ method in search activity. r=mfinkle