Closed Bug 1128521 Opened 5 years ago Closed 5 years ago

crash in java.lang.NoSuchMethodError: org.mozilla.search.SearchActivity.isDestroyed at org.mozilla.search.SearchActivity$6.onAnimationEnd(SearchActivity.java)

Categories

(Firefox for Android Graveyard :: Search Activity, defect, critical)

38 Branch
ARM
Android
defect
Not set
critical

Tracking

(firefox36+ fixed, firefox37+ fixed, firefox38+ fixed, fennec36+)

RESOLVED FIXED
Firefox 38
Tracking Status
firefox36 + fixed
firefox37 + fixed
firefox38 + fixed
fennec 36+ ---

People

(Reporter: aaronmt, Assigned: Margaret)

References

Details

(Keywords: crash)

Crash Data

Attachments

(1 file, 1 obsolete file)

This bug was filed from the Socorro interface and is 
report bp-55f5fe3a-8d5e-4e1c-bc8f-695992150201.
=============================================================

java.lang.NoSuchMethodError: org.mozilla.search.SearchActivity.isDestroyed
	at org.mozilla.search.SearchActivity$6.onAnimationEnd(SearchActivity.java:344)
	at com.nineoldandroids.animation.AnimatorSet$AnimatorSetListener.onAnimationEnd(AnimatorSet.java:756)
	at com.nineoldandroids.animation.ValueAnimator.endAnimation(ValueAnimator.java:1034)
	at com.nineoldandroids.animation.ValueAnimator.access$900(ValueAnimator.java:43)
	at com.nineoldandroids.animation.ValueAnimator$AnimationHandler.handleMessage(ValueAnimator.java:669)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:153)
	at android.app.ActivityThread.main(ActivityThread.java:5006)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:821)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:584)
	at dalvik.system.NativeStart.main(Native Method)
Crap.

[Tracking Requested - why for this release]: Regression from bug 1089653.
Assignee: nobody → margaret.leibovic
Blocks: 1089653
tracking-fennec: --- → 36+
/r/3289 - Bug 1128521 - Don't use API 17+ method in search activity. r=mfinkle

Pull down this commit:

hg pull review -r 84dcdf3e202095ca403b1aac13ed976953f87ce2
Attachment #8558687 - Flags: review?(mark.finkle)
https://reviewboard.mozilla.org/r/3289/#review2703

LGTM. If this is still racing with the onDestroy, we could move the searchEngineManager destruction above the super.onDestroy() in an attempt to clear out the state ASAP.
Comment on attachment 8558687 [details]
MozReview Request: bz://1128521/margaret

https://reviewboard.mozilla.org/r/3287/#review2709

Ship It!
Attachment #8558687 - Flags: review?(mark.finkle) → review+
Comment on attachment 8558687 [details]
MozReview Request: bz://1128521/margaret

Approval Request Comment
[Feature/regressing bug #]: bug 1089653 
[User impact if declined]: search activity will crash on devices running Android < 4.2
[Describe test coverage new/current, TreeHerder]: no automated tests, tested locally
[Risks and why]: adds a null check (same risk profile as bug 1089653, except this time I did the patch correctly!)
[String/UUID change made/needed]: none
Attachment #8558687 - Flags: approval-mozilla-beta?
Attachment #8558687 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/cceedc43a9ec
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
Attachment #8558687 - Flags: approval-mozilla-beta?
Attachment #8558687 - Flags: approval-mozilla-beta+
Attachment #8558687 - Flags: approval-mozilla-aurora?
Attachment #8558687 - Flags: approval-mozilla-aurora+
Attachment #8558687 - Attachment is obsolete: true
Attachment #8619287 - Flags: review+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.