Use the smtp.mozilla.com host for sending e-mails

RESOLVED FIXED

Status

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: davehunt, Assigned: Bebe)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

It appears that a couple of tests send e-mails via SMTP to check they are received in the e-mail app. These are currently set up to use smtp.gmail.com, but we would need to open a firewall route to allow this from our datacenter. It would be better if we can instead use smtp.mozilla.com.

I recommend a new 'smtp' key in the 'email' test variables, which will be used when we send e-mails from Python rather than from the devices themselves. Something like:

"email" {
  "smtp": {
    "email": "fxos-automation@mozilla.com",
    "hostname": "smtp.mozilla.com",
    "port": 25
  }
}

I also noticed that EmailUtil assumes a password will be present, however this should be conditional. When sending e-mail from our datacenter there's no requirement for authentication.
Assignee: nobody → florin.strugariu
QA Whiteboard: [fxosqa-auto-s9]
Attachment #8559883 - Flags: review?(dave.hunt)
Attachment #8559881 - Flags: review?(dave.hunt) → review-
Attachment #8559883 - Flags: review?(dave.hunt) → review-
Attachment #8559881 - Flags: review- → review?(dave.hunt)
Attachment #8559883 - Flags: review- → review?(dave.hunt)
Bebe: The patches look good, but the commit messages do not reflect the changes. Please update these so I can merge them.
Flags: needinfo?(florin.strugariu)
Done

Dave I think this can be merged
Flags: needinfo?(florin.strugariu)
Comment on attachment 8559881 [details] [review]
Link to Github pull-request: https://github.com/mozilla/webqa-credentials/pull/190

I tweaked the commit message on landing: https://github.com/mozilla/webqa-credentials/commit/9b1fd83b5c7153a4a5503d5a4d98b47e68167543

Once we're confident our nodes have pulled the latest credentials files we can merge the gaia patch.
Flags: needinfo?(dave.hunt)
Attachment #8559881 - Flags: review?(dave.hunt) → review+
Flags: needinfo?(dave.hunt)
Attachment #8559883 - Flags: review?(dave.hunt) → review+
Landed in:
https://github.com/mozilla-b2g/gaia/commit/4c0805f9b7a9d5fdcf7dee2658d98e0b1f16033e
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.