Whitelist Self Repair (self-repair.mozilla.org) origin for UITour

RESOLVED FIXED in Firefox 37

Status

()

Firefox
Tours
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Dexter, Assigned: Dexter)

Tracking

Trunk
Firefox 38
Points:
---

Firefox Tracking Flags

(firefox37 fixed, firefox38 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
We need to whitelist |self-repair.mozilla.org| to use UITour in [1].

[1] - http://mxr.mozilla.org/mozilla-central/source/browser/app/default_permissions?force=1
(Assignee)

Updated

3 years ago
Blocks: 1111016
(Assignee)

Updated

3 years ago
Assignee: nobody → alessio.placitelli
(Assignee)

Comment 1

3 years ago
Created attachment 8557980 [details] [diff] [review]
bug1128564.patch

For some reason, |default_permissions| file has Windows line endings on my machines (even though HG forces LF).
Attachment #8557980 - Flags: review?(MattN+bmo)
 is self-repair.mozilla.org right, or will it be something else?  (CDN-ish)?
Flags: needinfo?(chris.lonnen)

Comment 3

3 years ago
That is correct. It's a CDN under the hood, but that detail is unimportant to include in the URL. http:// is working now, and I'm actively working with C to set up https://
Flags: needinfo?(chris.lonnen)
Attachment #8557980 - Flags: review?(MattN+bmo) → review+
(Assignee)

Updated

3 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/8487c436c49b
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/8487c436c49b
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox38: --- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
(Assignee)

Comment 6

3 years ago
Comment on attachment 8557980 [details] [diff] [review]
bug1128564.patch

We would like to uplift this to beta to make Firefox 37 Beta 2. This should be uplifted together with the following bugs (order matters):

* 1128500 (introduces the HiddenFrame object)
* 1126756 (allows UITour to cleanup properly)
* 1128564 (this bug)
* 1111022 (Self-Support backend)

[Feature/regressing bug #]:
Needed for heartbeat / selfsupport v0, bug 1111016

[User impact if declined]:
Heartbeat and self-support will not be available for the user.

[Describe test coverage new/current, TreeHerder]:
[Risks and why]: Low risk isolated to self support not being able to execute UITour functions.
[String/UUID change made/needed]: No
Attachment #8557980 - Flags: approval-mozilla-beta?
Comment on attachment 8557980 [details] [diff] [review]
bug1128564.patch

Trivial Heartbeat change. Beta+
Attachment #8557980 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.