Closed
Bug 1128564
Opened 9 years ago
Closed 9 years ago
Whitelist Self Repair (self-repair.mozilla.org) origin for UITour
Categories
(Firefox :: Tours, defect)
Firefox
Tours
Tracking
()
RESOLVED
FIXED
Firefox 38
People
(Reporter: Dexter, Assigned: Dexter)
References
Details
Attachments
(1 file)
926 bytes,
patch
|
MattN
:
review+
lmandel
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
We need to whitelist |self-repair.mozilla.org| to use UITour in [1]. [1] - http://mxr.mozilla.org/mozilla-central/source/browser/app/default_permissions?force=1
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → alessio.placitelli
Assignee | ||
Comment 1•9 years ago
|
||
For some reason, |default_permissions| file has Windows line endings on my machines (even though HG forces LF).
Attachment #8557980 -
Flags: review?(MattN+bmo)
is self-repair.mozilla.org right, or will it be something else? (CDN-ish)?
Flags: needinfo?(chris.lonnen)
Comment 3•9 years ago
|
||
That is correct. It's a CDN under the hood, but that detail is unimportant to include in the URL. http:// is working now, and I'm actively working with C to set up https://
Flags: needinfo?(chris.lonnen)
Updated•9 years ago
|
Attachment #8557980 -
Flags: review?(MattN+bmo) → review+
Assignee | ||
Updated•9 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/8487c436c49b
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/8487c436c49b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox38:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8557980 [details] [diff] [review] bug1128564.patch We would like to uplift this to beta to make Firefox 37 Beta 2. This should be uplifted together with the following bugs (order matters): * 1128500 (introduces the HiddenFrame object) * 1126756 (allows UITour to cleanup properly) * 1128564 (this bug) * 1111022 (Self-Support backend) [Feature/regressing bug #]: Needed for heartbeat / selfsupport v0, bug 1111016 [User impact if declined]: Heartbeat and self-support will not be available for the user. [Describe test coverage new/current, TreeHerder]: [Risks and why]: Low risk isolated to self support not being able to execute UITour functions. [String/UUID change made/needed]: No
Attachment #8557980 -
Flags: approval-mozilla-beta?
Comment 7•9 years ago
|
||
Comment on attachment 8557980 [details] [diff] [review] bug1128564.patch Trivial Heartbeat change. Beta+
Attachment #8557980 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 8•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/de7488acda8a
status-firefox37:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•