Closed Bug 1128574 Opened 9 years ago Closed 9 years ago

Add JSHint to fireplace

Categories

(Marketplace Graveyard :: Code Quality, defect, P4)

Product:
Marketplace Graveyard
Component:
Code Quality
Version:
Avenir
Platform:
x86
macOS
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mstriemer, Assigned: mstriemer)

References

Details

We should start linting our code in the test suite so that everything conforms to our style guide. Add jshint to the fireplace Travis build and provide an easy way to run it locally (probably in `make test` and `make lint`).
Which repositories are you expecting to do this on, all of them?
Priority: -- → P4
I added it to the marketplace-core-modules PR already. I was just thinking fireplace but it's probably worth going through and hitting all the commonplace repos.
https://github.com/mozilla/fireplace/commit/de371054873391d7b9bf351b4656ba319ae10988
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Blocks: 1150972
No longer blocks: 1127432
You need to log in before you can comment on or make changes to this bug.