1128584 - ValueError: Failed to convert value OK of type unicode for field expected to type SubStatus

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect)

Description

[Dave Townsend [:mossop]]

Attachment: patch

The attached patch causes a failure in the xpcshell test toolkit/mozapps/extensions/test/xpcshell/test_disable.js but I can't see exactly what because the python code seems to die trying to display it:

0:02.22 LOG: MainThread INFO Following exceptions were raised:
 0:02.22 LOG: MainThread ERROR Traceback (most recent call last):
  File "/Users/dave/mozilla/source/trunk/testing/xpcshell/runxpcshelltests.py", line 159, in run
    self.run_test()
  File "/Users/dave/mozilla/source/trunk/testing/xpcshell/runxpcshelltests.py", line 700, in run_test
    self.log_full_output(self.output_lines)
  File "/Users/dave/mozilla/source/trunk/testing/xpcshell/runxpcshelltests.py", line 516, in log_full_output
    self.log_line(line)
  File "/Users/dave/mozilla/source/trunk/testing/xpcshell/runxpcshelltests.py", line 508, in log_line
    self.log.log_raw(line)
  File "/Users/dave/mozilla/source/trunk/testing/mozbase/mozlog/mozlog/structured/structuredlog.py", line 176, in log_raw
    converted_data = convertor_registry[action].convert_known(**raw_data)
  File "/Users/dave/mozilla/source/trunk/testing/mozbase/mozlog/mozlog/structured/logtypes.py", line 99, in convert_known
    return self.convert(**known_kwargs)
  File "/Users/dave/mozilla/source/trunk/testing/mozbase/mozlog/mozlog/structured/logtypes.py", line 88, in convert
    out_value = self.args[key](value)
  File "/Users/dave/mozilla/source/trunk/testing/mozbase/mozlog/mozlog/structured/logtypes.py", line 121, in __call__
    (value, type(value).__name__, self.name, self.__class__.__name__))
ValueError: Failed to convert value OK of type unicode for field expected to type SubStatus

Error running mach:

    ['xpcshell-test', 'toolkit/mozapps/extensions/test/xpcshell/test_disable.js']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

ValueError: Failed to convert value OK of type unicode for field expected to type SubStatus

  File "/Users/dave/mozilla/source/trunk/testing/xpcshell/mach_commands.py", line 481, in run_xpcshell_test
    return xpcshell.run_test(**params)
  File "/Users/dave/mozilla/source/trunk/testing/xpcshell/mach_commands.py", line 129, in run_test
    return self._run_xpcshell_harness(**args)
  File "/Users/dave/mozilla/source/trunk/testing/xpcshell/mach_commands.py", line 207, in _run_xpcshell_harness
    result = xpcshell.runTests(**filtered_args)
  File "/Users/dave/mozilla/source/trunk/testing/xpcshell/runxpcshelltests.py", line 1375, in runTests
    raise exceptions[0]

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Attachment: Only log valid status values when processing errors in xpcshell's head.js

I don't get the exception from comment 0 when I try this locally, but based on
the stack, I think this should address it.

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 8558013 [details] [diff] [review]
Only log valid status values when processing errors in xpcshell's head.js

Yeah that fixes it

Comment 3

[Chris Manchester (limited bugmail, email directly)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3adfa33cef51

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3adfa33cef51