1128605 - [Raptor] Assign application PID earlier in launch process to aid in problem recovery

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::PerformanceTest, defect)

Description

[:Eli Perelman]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia-node-modules/pull/86

Currently if a problem occurs in the launch of an application, we try to recover by killing the application process and recovering. What isn't helpful is that we don't capture the app's PID until it is fully loaded, so it's pretty unlikely we will have a problem occur after fully loaded or that we have the PID earlier. We should set the PID of the launching application as soon as we have it so that if we need to kill the app and restart we have a much better chance of being able to do so.

Comment 1

[:Eli Perelman]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/raptor/pull/10

Moving PID capture earlier in launch process. Also bumping package version to account for last few merges.

Comment 2

[Robert Wood [:rwood]]

Comment on attachment 8558029 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/raptor/pull/10

LGTM and works great. Tested by running launch test on flame and emulator, verifying the application PID was captured and the app killed accordingly.

Comment 3

[GitHub Autolander Bot]

Attachment: [PullReq] eliperelman:bug-1128605 to mozilla-b2g:master

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8558614 [details] [review]
[PullReq] eliperelman:bug-1128605 to mozilla-b2g:master

I'm fine leaving an R+ here for the simple package bump.

I am a bit worried that our dependencies are going to get out of control, we may want to start watching that soon. Looks good for now. Feel free to apply the R+ to the gaia node_modules.revision bump as well.

Comment 5

[GitHub Autolander Bot]

Attachment: [PullReq] eliperelman:bug-1128605 to mozilla-b2g:master

Comment 6

[:Eli Perelman]

Comment on attachment 8558618 [details] [review]
[PullReq] eliperelman:bug-1128605 to mozilla-b2g:master

Carrying over R+ based on comment 4.

Comment 7

[:Eli Perelman]

Try run: https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=88ecbdb78833
In master: https://github.com/mozilla-b2g/gaia/commit/dfebaaa8aab43470f482d09d71137bab840c3ae9