Closed Bug 1128654 Opened 9 years ago Closed 9 years ago

Add minor updates to Firefox Puppeteer documentation

Categories

(Testing :: Firefox UI Tests, defect)

Product:
Testing
Component:
Firefox UI Tests
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla38

People

(Reporter: galgeek, Assigned: galgeek)

Details

Attachments

(1 file)

github_pull_request.txt
51 bytes, text/x-github-pull-request
whimboo
: review+
chmanchester
: feedback+
Details | Review 
Reviewing Firefox Puppeteer documentation ahead of Tuesday's training, I see that some minor updates would be helpful.
Assignee: nobody → galgeek

        Attachment #8558076 -
        Flags: review?(cmanchester)

    
    

    
  
Comment on attachment 8558076 [details] [review]
github_pull_request.txt

This looks good, thanks again.

        Attachment #8558076 -
        Flags: review?(cmanchester) → review+

    
    

    
  
Comment on attachment 8558076 [details] [review]
github_pull_request.txt

There are still changes which are unclear and which need to be fixed. Some are great, but others make it worse IMO. It's also not completely consistent. So I made a couple of notes on the PR, which you might want to fix.

I would suggest you wait until my large patch on bug 1127831 landed.

        Attachment #8558076 -
        Flags: review-

    
    

    
  
I've backed out edits to firefox_puppeteer/ui/tabbar.py and otherwise updated per Henrik's github comments.

I see that his PR also edits firefox_puppeteer/ui/windows.py, as does mine. I'm not sure I see any places they're likely to interfere, still, I'm sure it's best to do as Henrik suggests above and land this only after Bug 1127831.

    
  

        Attachment #8558076 -
        Flags: review?(hskupin)

        Attachment #8558076 -
        Flags: review?(cmanchester)

    
    

    
  
Comment on attachment 8558076 [details] [review]
github_pull_request.txt

This still looks good to me, let's get final sign off from Henrik.

        Attachment #8558076 -
        Flags: review?(cmanchester)

        Attachment #8558076 -
        Flags: review+

        Attachment #8558076 -
        Flags: feedback+

    
    

    
  
I've again updated, per Henrik's comment on github.

    
  
Summary: Update Firefox Puppeteer documentation → Add minor updates to Firefox Puppeteer documentation

    
    

    
  
Comment on attachment 8558076 [details] [review]
github_pull_request.txt

The PR needs an update because it cannot be merged anymore.

        Attachment #8558076 -
        Flags: review?(hskupin)

    
    

    
  
Comment on attachment 8558076 [details] [review]
github_pull_request.txt

I've rebased and updated per feedback on github.

        Attachment #8558076 -
        Flags: review- → review?(hskupin)

        Attachment #8558076 -
        Flags: review?(hskupin) → review+

    
    

    
  
Landed as: https://github.com/mozilla/firefox-ui-tests/commit/48827d8331bab07ce0eafe819602c928af823486
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
Product: Mozilla QA → Testing

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: