Add minor updates to Firefox Puppeteer documentation

RESOLVED FIXED in mozilla38

Status

Testing
Firefox UI Tests
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: galgeek, Assigned: galgeek)

Tracking

unspecified
mozilla38
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

51 bytes, text/x-github-pull-request
whimboo
: review+
chmanchester
: feedback+
Details | Review | Splinter Review
(Assignee)

Description

3 years ago
Reviewing Firefox Puppeteer documentation ahead of Tuesday's training, I see that some minor updates would be helpful.
(Assignee)

Updated

3 years ago
Assignee: nobody → galgeek
(Assignee)

Comment 1

3 years ago
Created attachment 8558076 [details] [review]
github_pull_request.txt
Attachment #8558076 - Flags: review?(cmanchester)
Comment on attachment 8558076 [details] [review]
github_pull_request.txt

This looks good, thanks again.
Attachment #8558076 - Flags: review?(cmanchester) → review+
Comment on attachment 8558076 [details] [review]
github_pull_request.txt

There are still changes which are unclear and which need to be fixed. Some are great, but others make it worse IMO. It's also not completely consistent. So I made a couple of notes on the PR, which you might want to fix.

I would suggest you wait until my large patch on bug 1127831 landed.
Attachment #8558076 - Flags: review-
(Assignee)

Comment 4

3 years ago
I've backed out edits to firefox_puppeteer/ui/tabbar.py and otherwise updated per Henrik's github comments.

I see that his PR also edits firefox_puppeteer/ui/windows.py, as does mine. I'm not sure I see any places they're likely to interfere, still, I'm sure it's best to do as Henrik suggests above and land this only after Bug 1127831.
(Assignee)

Updated

3 years ago
Attachment #8558076 - Flags: review?(hskupin)
Attachment #8558076 - Flags: review?(cmanchester)
Comment on attachment 8558076 [details] [review]
github_pull_request.txt

This still looks good to me, let's get final sign off from Henrik.
Attachment #8558076 - Flags: review?(cmanchester)
Attachment #8558076 - Flags: review+
Attachment #8558076 - Flags: feedback+
(Assignee)

Comment 6

3 years ago
I've again updated, per Henrik's comment on github.
(Assignee)

Updated

3 years ago
Summary: Update Firefox Puppeteer documentation → Add minor updates to Firefox Puppeteer documentation
Comment on attachment 8558076 [details] [review]
github_pull_request.txt

The PR needs an update because it cannot be merged anymore.
Attachment #8558076 - Flags: review?(hskupin)
(Assignee)

Comment 8

3 years ago
Comment on attachment 8558076 [details] [review]
github_pull_request.txt

I've rebased and updated per feedback on github.
Attachment #8558076 - Flags: review- → review?(hskupin)
Attachment #8558076 - Flags: review?(hskupin) → review+
Landed as: https://github.com/mozilla/firefox-ui-tests/commit/48827d8331bab07ce0eafe819602c928af823486
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Flags: in-testsuite-
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
Product: Mozilla QA → Testing
You need to log in before you can comment on or make changes to this bug.