Closed
Bug 1128698
Opened 9 years ago
Closed 9 years ago
hooks should not prevent strips from completing
Categories
(Developer Services :: Mercurial: hg.mozilla.org, defect)
Developer Services
Mercurial: hg.mozilla.org
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gps, Unassigned)
References
Details
Attachments
(13 files, 1 obsolete file)
|
39 bytes,
text/x-review-board-request
|
bkero
:
review+
|
Details |
|
39 bytes,
text/x-review-board-request
|
bkero
:
review+
|
Details |
|
39 bytes,
text/x-review-board-request
|
bkero
:
review+
|
Details |
|
39 bytes,
text/x-review-board-request
|
bkero
:
review+
|
Details |
|
39 bytes,
text/x-review-board-request
|
bkero
:
review+
|
Details |
|
39 bytes,
text/x-review-board-request
|
bkero
:
review+
|
Details |
|
39 bytes,
text/x-review-board-request
|
bkero
:
review+
|
Details |
|
39 bytes,
text/x-review-board-request
|
bkero
:
review+
|
Details |
|
39 bytes,
text/x-review-board-request
|
bkero
:
review+
|
Details |
|
39 bytes,
text/x-review-board-request
|
bkero
:
review+
|
Details |
|
39 bytes,
text/x-review-board-request
|
bkero
:
review+
|
Details |
|
39 bytes,
text/x-review-board-request
|
bkero
:
review+
|
Details |
|
39 bytes,
text/x-review-board-request
|
bkero
:
review+
|
Details |
Mercurial fires the pretxnchangegroup and similar hooks during `hg strip` when it applies the backup bundle to the repository. Our existing hooks will often reject the backup bundle application for whatever reason (tree closure, multiple heads, etc). We should rewrite all our hooks that block changes to ignore changegroups where source=='strip'. (This issue is responsible for me temporarily corruption the Aurora repo last week due to a broken strip operation.)
|
Reporter | |
Comment 1•9 years ago
|
||
/r/3335 - hghooks: test bad strip behavior in commit-message.py hook /r/3337 - hghooks: don't process strips from commit-message hook (bug 1128698) /r/3339 - hghooks: add test showing prevent_string_changes exhibits wrong stripping behavior /r/3341 - hghooks: don't process strips from prevent_string_changes hook (bug 1128698) /r/3343 - hghooks: add test showing that prevent_uuid_changes disallows strip /r/3345 - hghooks: don't process strips in prevent_uuid_changes hook (bug 1128698) Pull down these commits: hg pull review -r 10750a32148889eae21655b9e96fac77a9fbbd5f
|
|
Reporter | |
Updated•9 years ago
|
Attachment #8559525 -
Flags: review?(bkero)
|
|
Reporter | |
Comment 2•9 years ago
|
||
Comment on attachment 8559525 [details] MozReview Request: bz://1128698/gps /r/3335 - hghooks: test bad strip behavior in commit-message.py hook /r/3337 - hghooks: don't process strips from commit-message hook (bug 1128698) /r/3339 - hghooks: add test showing prevent_string_changes exhibits wrong stripping behavior /r/3341 - hghooks: don't process strips from prevent_string_changes hook (bug 1128698) /r/3343 - hghooks: add test showing that prevent_uuid_changes disallows strip /r/3345 - hghooks: don't process strips in prevent_uuid_changes hook (bug 1128698) /r/3507 - hghooks: add test showing prevent_webidl_changes prevents strips /r/3509 - hghooks: don't process strips in prevent_webidl_changes hook (bug 1128698) /r/3511 - hghooks: add test showing that treeclosure prevents stripping /r/3513 - hghooks: don't process strips from treeclosure hook (bug 1128698) /r/3515 - hghooks: don't process strips in treeclosure_comm_central hook (bug 1128698) /r/3517 - hghooks: don't process strips from try_mandatory hook (bug 1128698) /r/3519 - hghooks: don't process strips from whitelist_* hooks (bug 1128698) Pull down these commits: hg pull review -r 5f2d38269e17eb5bc1c26bb5c47495264bb2d9d2
|
||
Comment 3•9 years ago
|
||
https://reviewboard.mozilla.org/r/3335/#review2857 Ship It!
|
|
||
Comment 4•9 years ago
|
||
https://reviewboard.mozilla.org/r/3337/#review2859 Ship It!
|
|
||
Comment 5•9 years ago
|
||
https://reviewboard.mozilla.org/r/3339/#review2861 Ship It!
|
|
||
Comment 6•9 years ago
|
||
https://reviewboard.mozilla.org/r/3341/#review2863 Ship It!
|
|
||
Comment 7•9 years ago
|
||
https://reviewboard.mozilla.org/r/3343/#review2865 Ship It!
|
|
||
Comment 8•9 years ago
|
||
https://reviewboard.mozilla.org/r/3345/#review2867 Ship It!
|
|
||
Comment 9•9 years ago
|
||
https://reviewboard.mozilla.org/r/3507/#review2869 Ship It!
|
|
||
Comment 10•9 years ago
|
||
https://reviewboard.mozilla.org/r/3509/#review2871 Ship It!
|
|
||
Comment 11•9 years ago
|
||
https://reviewboard.mozilla.org/r/3511/#review2873 Ship It!
|
|
||
Comment 12•9 years ago
|
||
https://reviewboard.mozilla.org/r/3513/#review2875 Ship It!
|
|
||
Comment 13•9 years ago
|
||
https://reviewboard.mozilla.org/r/3515/#review2877 Ship It!
|
|
||
Comment 14•9 years ago
|
||
https://reviewboard.mozilla.org/r/3517/#review2879 Ship It!
|
|
||
Comment 15•9 years ago
|
||
https://reviewboard.mozilla.org/r/3519/#review2881 Ship It!
|
|
Reporter | |
Comment 16•9 years ago
|
||
https://hg.mozilla.org/hgcustom/version-control-tools/rev/4816d9611b08 https://hg.mozilla.org/hgcustom/version-control-tools/rev/5c43150148c0 https://hg.mozilla.org/hgcustom/version-control-tools/rev/5b5df02b6e0c https://hg.mozilla.org/hgcustom/version-control-tools/rev/791340bd0fb0 https://hg.mozilla.org/hgcustom/version-control-tools/rev/6c21c639b896 https://hg.mozilla.org/hgcustom/version-control-tools/rev/7e279c598404 https://hg.mozilla.org/hgcustom/version-control-tools/rev/af986f96758c https://hg.mozilla.org/hgcustom/version-control-tools/rev/33a0fa9dc70d
|
|
||
Comment 17•9 years ago
|
||
Comment on attachment 8559525 [details] MozReview Request: bz://1128698/gps https://reviewboard.mozilla.org/r/3333/#review2885 Ship It!
Attachment #8559525 -
Flags: review?(bkero) → review+
|
|
Reporter | |
Comment 18•9 years ago
|
||
I have synchronized mozhghooks on hgssh and hgweb machines.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 19•9 years ago
|
||
Attachment #8559525 -
Attachment is obsolete: true
Attachment #8619294 -
Flags: review+
Attachment #8619295 -
Flags: review+
Attachment #8619296 -
Flags: review+
Attachment #8619297 -
Flags: review+
Attachment #8619298 -
Flags: review+
Attachment #8619299 -
Flags: review+
Attachment #8619300 -
Flags: review+
Attachment #8619301 -
Flags: review+
Attachment #8619302 -
Flags: review+
Attachment #8619303 -
Flags: review+
Attachment #8619304 -
Flags: review+
Attachment #8619305 -
Flags: review+
Attachment #8619306 -
Flags: review+
|
|
Reporter | |
Comment 20•9 years ago
|
||
|
|
Reporter | |
Comment 21•9 years ago
|
||
|
|
Reporter | |
Comment 22•9 years ago
|
||
|
|
Reporter | |
Comment 23•9 years ago
|
||
|
|
Reporter | |
Comment 24•9 years ago
|
||
|
|
Reporter | |
Comment 25•9 years ago
|
||
|
|
Reporter | |
Comment 26•9 years ago
|
||
|
|
Reporter | |
Comment 27•9 years ago
|
||
|
|
Reporter | |
Comment 28•9 years ago
|
||
|
|
Reporter | |
Comment 29•9 years ago
|
||
|
|
Reporter | |
Comment 30•9 years ago
|
||
|
|
Reporter | |
Comment 31•9 years ago
|
||
|
|
Reporter | |
Comment 32•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•