Mark DMD directories as FAIL_ON_WARNINGS breaks b2g builds

RESOLVED FIXED in Firefox 40

Status

()

Core
DMD
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: erahm, Assigned: jld)

Tracking

unspecified
mozilla40
All
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

Bug 1122337 is causing failures when building b2g + dmd (at least for flame-kk):

/Users/ericrahm/dev/mozilla-central/memory/replace/dmd/DMD.cpp:63:0: error: "PAGE_SIZE" redefined [-Werror]
In file included from ../../../dist/system_wrappers/asm/page.h:3:0,
                 from /Volumes/firefoxos/B2G/bionic/libc/include/limits.h:109,
                 from /Users/ericrahm/dev/mozilla-central/build/stlport/stlport/limits.h:28,
                 from ../../../dist/system_wrappers/limits.h:3,
                 from /Users/ericrahm/dev/mozilla-central/memory/replace/dmd/DMD.cpp:9:
/Volumes/firefoxos/B2G/bionic/libc/kernel/arch-arm/asm/page.h:22:0: note: this is the location of the previous definition
nsClassInfoImpl.o
cc1plus: all warnings being treated as errors
(Assignee)

Comment 1

3 years ago
Created attachment 8594958 [details] [diff] [review]
Don't redefine PAGE_SIZE in DMD if it's already defined.
Assignee: nobody → jld
Attachment #8594958 - Flags: review?(erahm)
Comment on attachment 8594958 [details] [diff] [review]
Don't redefine PAGE_SIZE in DMD if it's already defined.

Review of attachment 8594958 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #8594958 - Flags: review?(erahm) → review+
(Assignee)

Comment 3

3 years ago
Checkin-needed note: DMD is NPOTB, but I pushed the patch to try along with a mozconfig change to enable it: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e51a3128ac51 (the ASan/Valgrind failures are expected).
Keywords: checkin-needed
(Assignee)

Comment 4

3 years ago
(In reply to Jed Davis [:jld] {UTC-7} from comment #3)
> but I pushed the patch to try along with a mozconfig change to enable it:
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=e51a3128ac51

Except that doesn't quite do what it looks like it does, because B2G builds don't use mozconfig.common.override.  But Android Firefox is also affected by this bug, and does use that file, and can be seen passing, so there's that.  (This is probably more work than I needed to put into testing something that's not part of the normal build, but since I've already done it I might as well try to explain what it actually tested.)
https://hg.mozilla.org/mozilla-central/rev/f78a9c56f0aa
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.