OSX DevEdition Theme: Pinned tab with overflowing tabs covers up the nav-bar box shadow

RESOLVED FIXED in Firefox 38

Status

()

Firefox
Theme
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bgrins, Assigned: bgrins)

Tracking

unspecified
Firefox 38
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [devedition-polish])

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
Created attachment 8558162 [details]
pinned-tab-border.png

See the screenshot and that the box shadow along the nav bar is interrupted by the pinned tab.  This appears to be OSX only.
(Assignee)

Comment 1

3 years ago
Created attachment 8558167 [details] [diff] [review]
pinned-overflow-fix.patch

Oddly, setting position:fixed here [0] is causing the background of the tab to overlap the negative box shadow on the nav-bar [1] added in Bug 1097595.  To fix this, we can remove the background on the tab anyway, since it matches the tab bar.

Note, this won't be true for Windows after Bug 1093820, but we can just set the background color on tabs only for Windows there, especially since it doesn't suffer from this bug.

[0]: https://dxr.mozilla.org/mozilla-central/source/browser/base/content/browser.css#178
[1]: https://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/devedition.inc.css#245
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Attachment #8558167 - Flags: review?(gijskruitbosch+bugs)
(Assignee)

Updated

3 years ago
Blocks: 1097595
(Assignee)

Updated

3 years ago
Blocks: 1093820

Updated

3 years ago
Attachment #8558167 - Flags: review?(gijskruitbosch+bugs) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
(Assignee)

Comment 2

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/b597830d7034
Keywords: checkin-needed
Whiteboard: [devedition-polish] → [fixed-in-fx-team][devedition-polish]
https://hg.mozilla.org/mozilla-central/rev/b597830d7034
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team][devedition-polish] → [devedition-polish]
Target Milestone: --- → Firefox 38
QA Whiteboard: [good first verify]

Comment 4

3 years ago
This is now fine in my  Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:40.0) Gecko/20100101 Firefox/40.0
You need to log in before you can comment on or make changes to this bug.