Closed
Bug 1128719
Opened 10 years ago
Closed 10 years ago
OSX DevEdition Theme: Pinned tab with overflowing tabs covers up the nav-bar box shadow
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 38
People
(Reporter: bgrins, Assigned: bgrins)
References
Details
(Whiteboard: [devedition-polish])
Attachments
(2 files)
29.33 KB,
image/png
|
Details | |
989 bytes,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
See the screenshot and that the box shadow along the nav bar is interrupted by the pinned tab. This appears to be OSX only.
Assignee | ||
Comment 1•10 years ago
|
||
Oddly, setting position:fixed here [0] is causing the background of the tab to overlap the negative box shadow on the nav-bar [1] added in Bug 1097595. To fix this, we can remove the background on the tab anyway, since it matches the tab bar.
Note, this won't be true for Windows after Bug 1093820, but we can just set the background color on tabs only for Windows there, especially since it doesn't suffer from this bug.
[0]: https://dxr.mozilla.org/mozilla-central/source/browser/base/content/browser.css#178
[1]: https://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/devedition.inc.css#245
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Attachment #8558167 -
Flags: review?(gijskruitbosch+bugs)
Updated•10 years ago
|
Attachment #8558167 -
Flags: review?(gijskruitbosch+bugs) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 2•10 years ago
|
||
Keywords: checkin-needed
Whiteboard: [devedition-polish] → [fixed-in-fx-team][devedition-polish]
Comment 3•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team][devedition-polish] → [devedition-polish]
Target Milestone: --- → Firefox 38
Updated•10 years ago
|
QA Whiteboard: [good first verify]
Comment 4•10 years ago
|
||
This is now fine in my Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:40.0) Gecko/20100101 Firefox/40.0
You need to log in
before you can comment on or make changes to this bug.
Description
•