1128773 - Executing javascript function loaded with import_script fails

Status: RESOLVED WONTFIX

(Remote Protocol :: Marionette, defect)

Description

[Eric Rahm [:erahm]]

While running the full AWSY tests I ran into some situations where running the function |createCheckpoint| that is defined in a separate js script[1] that gets loaded fails due to |createCheckpoint| not being defined.

Code snippet:
>        self.logger.info("starting checkpoint %s..." % checkpoint)
>        js = os.path.abspath(os.path.join(__file__, os.path.pardir, "checkpoint.js"))
>        self.marionette.import_script(js)
>        checkpoint = None
>        try:
>          checkpoint = self.marionette.execute_async_script("createCheckpoint(\"%s\")" % checkpoint, script_timeout=60000)
>        except JavascriptException, e:
>          self.logger.error("Checkpoint JavaScript error: %s" % e)

And the error:
>17:57.57 LOG: MainThread ERROR Checkpoint JavaScript error: JavascriptException: ReferenceError: createCheckpoint is not defined
>stacktrace:
>        execute_async_script @test_memory_usage.py, line 217
>        inline javascript, line 0
>        src: "__marionetteParams.push(returnFunc);let marionetteScriptFinished = returnFunc;let __marionetteFunc = function() >{createCheckpoint("None")};__marionetteFunc.apply(null, __marionetteParams);"

[1] https://github.com/EricRahm/areweslimyet/blob/marionette/benchtester/checkpoint.js

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Do you have anything else to offer about when this fails and when it doesn't? This looks to me like a very typical use of import_script.

Comment 2

[Eric Rahm [:erahm]]

(In reply to Chris Manchester [:chmanchester] from comment #1)
> Do you have anything else to offer about when this fails and when it
> doesn't? This looks to me like a very typical use of import_script.

I'll attempt to reproduce and reduce locally.

Comment 3

[Eric Rahm [:erahm]]

This causes about a 75% failure rate for AWSY runs. That snippet of code is run 32 times over the duration of a test. It's hard for me to tell how quickly it fails unfortunately.

Comment 4

[Eric Rahm [:erahm]]

I spent a fair amount of time trying to reduce this to a small test case outside of AWSY and had no luck. As a work-around I just load the script through python rather than |import_script| and then pass that to |execute_async_script|. This seems to be working reasonably well and I haven't encountered any errors.

Comment 5

[David Burns :automatedtester]

import_script was removed as a feature.