steps to reproduce: 1. Load 2. Add all the required fields 3. Search for "Flamita" app 4. Save the collection expected behavior: Only public apps show up in search results in collection. Flamita doesn't exist anymore so it shouldn't show up. observed behavior: This deleted app shows up and causes the collection submission to fails. This gets hard when the collection has 20 apps to figure out which app is the culprit. screencast: http://screencast.com/t/R122cxyq6j1
It looks like this is intentional: https://github.com/mozilla/marketplace-operator-dashboard/blob/389b0d5af7f0be28b7797148e800e00e03b346fa/src/media/js/routes_api.js#L12 That ?filtering=0 disables any filtering from the API side, including status=PUBLIC or disabled apps: https://github.com/mozilla/zamboni/blob/696ccf33b7d78ed7929b99d3d408325bf212514d/mkt/webapps/indexers.py#L505 I think I vaguely remember this being a feature so that you can find apps that aren't yet public? Maybe chuck or someone who has worked on the curation tools knows?
This is a feature, not a bug, to allow Scott and operators to prep promotions with hidden/yet unpublished apps. That should not change. The actual bug here is that submission fails if these apps are present. I would call this a P3, unless it is making difficult a specific task.
Priority: P2 → P3
(In reply to Chuck Harmston [:chuck] from comment #2) > This is a feature, not a bug, to allow Scott and operators to prep > promotions with hidden/yet unpublished apps. That should not change. > > The actual bug here is that submission fails if these apps are present. I > would call this a P3, unless it is making difficult a specific task. I disagree. That app is deleted. It shouldn't show up. If Scott creates a collection with 20 apps in it and he needs to figure out which app is the culprit, that's a pain. https://marketplace.firefox.com/app/null is the app we are linking to from the Curation tools. I'd prefer to make this a P2.
This issue has come up in other instances where a developer submits two or more versions of the same app, but only has one live. When I search for the app and see multiple choices, there's no way to tell from within the Tool which is valid and which is not. Personally, I don't ever need to pre-load content that's not live yet. The risk of keeping this feature outweighs the potential rewards, imo, because what has happened on a couple of occasions is the entire collection is corrupted by a rogue app and it's painstaking to figure out the source of the problem.
Updated the search API to always exclude disabled apps and filter by apps whose status is in "VALID_STATUSES", which includes public apps and also pending, unlisted, and hidden. https://github.com/mozilla/zamboni/commit/f17d772
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
There was a regression in reviewer tools. I've reverted the patch for now until I have more time to fix it in a sane way for all parties that use this API.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Dropping priority since we know what is causing this now. If someone wants to take this on feel free to take the bug but I'll try to get to it next week.
Priority: P1 → P2
Target Milestone: 2015-02-10 → ---
I kinda went gung-ho on this and refactored our messy search filter code: https://github.com/mozilla/zamboni/pull/2906
https://github.com/mozilla/zamboni/commit/004911b In addition to verifying the issue in comment 0, please also verify that all search endpoints work as expected and there are no regressions. This includes the reviewer search and consumer facing search, and also the curation tools and operator shelf tools. The lookup tool isn't affected. Thanks.
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago → 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2015-02-17
(In reply to Rob Hudson [:robhudson] from comment #9) > https://github.com/mozilla/zamboni/commit/004911b > > In addition to verifying the issue in comment 0, please also verify that all > search endpoints work as expected and there are no regressions. This > includes the reviewer search and consumer facing search, and also the > curation tools and operator shelf tools. The lookup tool isn't affected. > > Thanks. I've rejected an app (Author (chimpanzee1947)) that was public and after that i've searched it. The rejected app was not listed in any of the cases above. Postfix screencast http://screencast.com/t/qm5Hki9k6 Closing bug.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.