112884 - How to extract the PQG parameters from a DSA private key?

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P1)

Description

[Jamie Nicolson]

Java's DSAPrivateKey type has methods allowing you to extract the PQG
parameters. What NSS method can I call to get the PQG parameters from a DSA
private key?

Comment 1

[Robert Relyea]

Attachment: Function to read PQG's from a DSA key.

Comment 2

[Wan-Teh Chang]

Comment on attachment 67748 [details] [diff] [review]
Function to read PQG's from a DSA key.

Hi Bob,

Just a minor problem in one of the error paths
in the new function.

>+SECKEYPQGParams *
>+PK11_GetPQGParamsFromPrivateKey(SECKEYPrivateKey *privKey)
>+{

[...]

>+
>+    arena = PORT_NewArena(2048);
>+    if (arena == NULL) {
>+	goto loser;
>+    }

We need to replace "goto loser" by "return NULL".
If we pass arena=NULL to PORT_FreeArena(), that
function will crash.

Comment 3

[Robert Relyea]

Oops, actually the intention was to check for NULL before freeing:


if (arena) {
    PORT_FreeArena(arena,FALSE);
}

bob

Comment 4

[Robert Relyea]

Reopen if function does not work.