Closed Bug 1128840 Opened 7 years ago Closed 7 years ago

[Demo][Stingray] When the card item at the far-left on the Home screen is selected, it should be a complete circle

Categories

(Firefox OS Graveyard :: Gaia::TV, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: cynthiatang, Assigned: rexboy)

References

Details

(Whiteboard: [Stingray-Branch][picked 3/3])

Attachments

(2 files)

Attached image screenshot
### ENV
Device: Flatfish (tv)
Gaia: ea6ac33469261bee75567e7cf0154d2e428d2097

### STR
1. Move the focus on the card item at the far-left on the Home screen 

### Actual Result
1. The card item that you selected is not a complete circle.

### Expected Result
1. The card item that you selected should be a complete circle.
Assignee: nobody → rexboy
Comment on attachment 8558968 [details] [review]
[PullReq] rexboy7:1128840-scrollable-left-margin to mozilla-b2g:master

Tzu-lin may you help reviewing this patch
If you feel it's not familiar block to you, you may pass it to John.
Thanks a lot!
Attachment #8558968 - Flags: review?(tzhuang)
Comment on attachment 8558968 [details] [review]
[PullReq] rexboy7:1128840-scrollable-left-margin to mozilla-b2g:master

I think John would be more familiar of this part than me. Pass review to John.
Attachment #8558968 - Flags: review?(tzhuang) → review?(im)
Comment on attachment 8558968 [details] [review]
[PullReq] rexboy7:1128840-scrollable-left-margin to mozilla-b2g:master

I found we should use another way to solve it for adapting edit-mode animation.
So I'll just cancel the review for now. Sorry for that.
Hope John hasn't start reviewing it yet.
Attachment #8558968 - Flags: review?(im)
Comment on attachment 8558968 [details] [review]
[PullReq] rexboy7:1128840-scrollable-left-margin to mozilla-b2g:master

I've updated the patch.

This patch also fixes polish requirement of bug 1129312. Please take a look if required. I fixed these two bug at once since they both involved in CSS transforming of card list.

John may you help review it?
Attachment #8558968 - Flags: review?(im)
Comment on attachment 8558968 [details] [review]
[PullReq] rexboy7:1128840-scrollable-left-margin to mozilla-b2g:master

looks good.
Attachment #8558968 - Flags: review?(im) → review+
https://github.com/mozilla-b2g/gaia/commit/e9b2d507f16867eb500334773f4e6a1b7f8dd686
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [Stingray-Branch][picked 3/3]
You need to log in before you can comment on or make changes to this bug.