Closed
Bug 1128844
Opened 9 years ago
Closed 9 years ago
Can't make a build only has System app
Categories
(Firefox OS Graveyard :: Gaia::Build, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jj.evelyn, Assigned: rickychien)
Details
Attachments
(2 files)
I'm trying to make a demo build which only includes system app, but my build failed with the following message: Exception: Error: Can not find application keyboardin webappsMapping It seems our build system assumes keyboard is must-have which doesn't make sense to me.
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Hey George, please kindly review this patch. Thanks!
Attachment #8559023 -
Flags: review?(gduan)
Assignee | ||
Updated•9 years ago
|
Status: NEW → ASSIGNED
Comment 3•9 years ago
|
||
Comment on attachment 8559023 [details] [review] Gaia PR r=gduan, but I think we should add an integration test to make sure manifesturl is written in keyboard_layout.json or we never know it's updated or not.
Attachment #8559023 -
Flags: review?(gduan) → review+
Assignee | ||
Comment 4•9 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/97f3b4d11a92bdcaf79edd8ff55e690bd446bac7 Merged it first. About integration test, I think checking manifestUrl would be a little superfluous because manifestUrl will be updated every time even though there doesn't exist a proper keyboard app. If you're still concern about that, we could file a follow-up to add test for it.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•