[RTL][Camera]The share icon is mirrored when user check the image preview.

VERIFIED FIXED

Status

P2
normal
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: lulu.tian, Assigned: dmarcos)

Tracking

unspecified
ARM
Gonk (Firefox OS)
Dependency tree / graph
Bug Flags:
in-moztrap +

Firefox Tracking Flags

(b2g-v2.2 verified, b2g-master verified)

Details

Attachments

(3 attachments)

(Reporter)

Description

4 years ago
[1.Description]:
[RTL][Camera]When user check the image preview, the share icon should not be mirrored, and its correct behavior should be the same as that in gallery app.
See attachment:shareicon.png

[2.Testing Steps]: 
Prerequisite: Set system language as Arabic.
1. Launch Camera app.
2. Take a photo.
3. Press the thumbnail icon at bottom left.
4. Observe the share icon at header.

[3.Expected Result]: 
4. The share icon should not be mirrored.

[4.Actual Result]: 
4. The share icon is mirrored, and sometimes when user press it, there is no response.

[5.Reproduction build]: 
Flame 2.2 build:
Gaia-Rev        d6141fa3208f224393269e17c39d1fe53b7e6a05
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/be206fa2fb60
Build-ID        20150202002507
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150202.035604
FW-Date         Mon Feb  2 03:56:15 EST 2015
Bootloader      L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

[8.Note]:
Sometimes, press the share and menu button when preview image, there is no response.
(Reporter)

Updated

4 years ago
QA Whiteboard: [rtl-impact]
(Reporter)

Comment 1

4 years ago
Created attachment 8558388 [details]
shareicon.png
feature-b2g: --- → 2.2+
Priority: -- → P2

Comment 2

4 years ago
Diego, can you take this up also?
Flags: needinfo?(dmarcos)
(Assignee)

Updated

4 years ago
Depends on: 1132230
Created attachment 8563161 [details] [review]
[gaia] dmarcos:bug1128861 > mozilla-b2g:v2.2
(Assignee)

Comment 4

4 years ago
Created attachment 8563162 [details] [review]
Pull Request

This is a hack. Icons should not be mirrored by default in RTL (longer explanation in bug 1132230). This patch reverts the transform applied here for only the share button:

https://github.com/mozilla-b2g/gaia/blob/master/shared/style/buttons.css#L403
Flags: needinfo?(dmarcos)
Attachment #8563162 - Flags: review?(dflanagan)
Re-triage: removing minor bugs from 2.2 scope. We'll still take a fix for this if 2.2 approval is granted before Feb 23.
feature-b2g: 2.2+ → ---
Comment on attachment 8563162 [details] [review]
Pull Request

This seems fine, except that the PR is against the 2.2 branch instead of against master.

I agree with you, though, that it would be better to just land the general fix in bug 1132230 and not land this one at all.  But the r+ is here if you need to land this one.
Attachment #8563162 - Flags: review?(dflanagan) → review+
Assignee: nobody → dmarcos
Test case has been added in moztrap:

https://moztrap.mozilla.org/manage/case/15921/
Flags: in-moztrap+
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
This issue is verified as fixed on Flame Master and 2.2 by the fix on bug 1132230.

Result: The share icon is NOT mirrored in RTL mode.

Device: Flame Master (KK, 319mb, full flash)
Build ID: 20150326010205
Gaia: 8dc256a2de273be3abfa2cb2103d872d677834f7
Gecko: 37d3dcbf23a9
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 39.0a1 (Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Device: Flame 2.2 (KK, 319mb, full flash)
Build ID: 20150326002504
Gaia: e59ac067a1d22b7a72cbebc892ec652723f2a557
Gecko: 04b4b9d1faae
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [rtl-impact] → [QAnalyst-Triage?][rtl-impact]
status-b2g-v2.2: affected → verified
status-b2g-master: --- → verified
Flags: needinfo?(ktucker)
QA Whiteboard: [QAnalyst-Triage?][rtl-impact] → [QAnalyst-Triage+][rtl-impact]
Flags: needinfo?(ktucker)
You need to log in before you can comment on or make changes to this bug.