1128905 - Combining diacritic causes incorrect autocorrect

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Friedel Wolff]

When a textarea already contains a combining diacritic, autocorrection after that point does not work correctly.

To reproduce:
 - Enter a letter with combining diacritic, for example "ɛ̂" (two Unicode code points)
 - type in a new word that will require autocorrect, for example "tect" (instead of "text")
 - Press the space bar to do the autocorrect

Expected:
 - "tect" should be replaced with "text"

Instead we see:
 - "tect" still in the text area, and the last three letters are highlighted.

If we started with two combining diacritics in the initial text (for example "ɛ̂ɛ̂" then the same will happen, but only the last two characters will be selected. If we start with four of them, no selection will be shown. This proves to me that the problem is with the combining diacritics, since the number of combining diacritics determines the length of the selection after pressing space (up to the length of the word).

Comment 1

[Jan Jongboom [:janjongboom] (inactive)]

Attachment: Video

Hi, I was investigating this, but doesn't happen for me (see video).

I use `el.value += '\u025B\u0302'` from JavaScript to append the char to the textbox.

Comment 2

[Jan Jongboom [:janjongboom] (inactive)]

Attachment: UI Test for reference

FYI, this is the test

Comment 3

[Friedel Wolff]

Thanks for looking into this Jan. I'm not familiar with the testing infrastructure. I can only think of one reason for this difference. Please say if this makes sense:

Since you directly edit el.value, instead of "typing" it through the keyboard app, could it be that the bug is in the entering of combining diacritics through the interface, rather than the autocorrect as I initially suggested? The keyboard app keeps book of the cursor position (variable `cursor` in latin.js). I'm wondering if that is where something is going wrong. Sorry that I can't put more time into this now.

Comment 4

[Jan Jongboom [:janjongboom] (inactive)]

Do you have a branch somewhere? Or which keyboard contains these characters?

Comment 5

[Jan Jongboom [:janjongboom] (inactive)]

If I have reproduction path it'd be more easy to say something about this :-)

Comment 6

[Friedel Wolff]

I used the layout "en-Africa" with the patch in bug 1125078 (blocked by this bug). I felt that this needs fixing before I send a pull request. Thanks for looking into it.

Comment 7

[Jan Jongboom [:janjongboom] (inactive)]

Attachment: weird-diacritics.png

More issues (on flame master). In the alt menu it's shown wrong.

Comment 8

[Jan Jongboom [:janjongboom] (inactive)]

Hi, the alt menu shows it wrong, and also inserts the char wrong, but autocorrect is not affected.

Can you put your current working branch on github so I can clone it in exactly the same state, and send me a video of the autocorrect issue?

Comment 9

[Jan Jongboom [:janjongboom] (inactive)]

Hmm, the issue with the display is a font problem in Open Sans. In Arial it renders fine...

Comment 10

[Friedel Wolff]

Sorry Jan, I realise things might have gotten lost between the bugs, but that patch is for Gaia 2.0, and that is all I'm testing now since I was told this is very urgent. Can you point so some documentation on doing a video? I'm not sure I'll be able to get to that before I'm away for a few days.

Comment 11

[Friedel Wolff]

Attachment: New Project.webm

This is a quick attempt at a video of what I see. To reiterate:
 - Gaia 2.0 (736933b25)
 - en-Africa layout with the extra patch in the blocked bug

Comment 12

[BMO Automation]

Firefox OS is not being worked on