1128913 - Tabcrash icon resize when changing Firefox width

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Bogdan Maris, Desktop QA]

Attachment: Screencast showing the issue

Reproducible in builds:
- Latest Nightly

Reproducible on OSs:
- Windows 7 64-bit
- Ubuntu 14.04 32-bit
- Mac OS X 10.9.5

STR:
1. Open Firefox.
2. Load about:tabcrashed.
3. Resize Firefox width.

Expected results: The icon does not change size and it disappears after a while.

Actual results: The icon increases size after a while then it disappears.

Notes:
1. This is a regression 

m-c:
Last good nightly: 2015-01-31
First bad Nightly: 2015-02-01

Last good revision: d7e156a7a0a6
First bad revision: c2359a6a6958

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d7e156a7a0a6&tochange=c2359a6a6958

m-i:
Last good revision: d0c5e3607389
First bad revision: c2359a6a6958

Pushlog:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=d0c5e3607389&tochange=c2359a6a6958

Probably caused by: bug 1112304

2. Reproduces on all platforms.

Comment 1

[Dave Townsend [:mossop]]

The bug here is with the styles added by bug. It seems to cause the icon height to match the height of the title element. Normally that is fine but when the text wraps to two lines it means the icon suddenly doubles in height. Bug 1112304 happened to make the English string long enough for that to happen before the icon was hidden but even without that it's likely another locale would run into the same problem.

Comment 2

[Tim Nguyen :ntim]

Attachment: Patch

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/165cb27ebbc9

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/165cb27ebbc9

Comment 5

[Bogdan Maris, Desktop QA]

Verified that the icon does not resize anymore using latest Nightly on Windows 8.1 64-bit, Windows 7 64-bit, Mac OS X 10.9.5 and Ubuntu 14.04 64-bit.

Comment 6

[David Lawrence [:dkl]]

Mistakenly filed against Firefox 38 and should be instead 38 Branch. Sorry for the spam. dkl