1128938 - User cannot edit the submitted review

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P1)

Description

[Valentina Virlics [:vvalentina], Ecosystem QA]

Steps to reproduce:
1. Sign in to MP-dev on your Android device
2. Go to any app and click the “Write a review” button
3. Submit the review
4. Edit your review 

Expected results:
Your review is updated. A success message is displayed.

Actual results:
Your review is not updated. A success message is displayed.

Notes/Issues:
Issue can be reproduce by clicking any of the edit review option.(link, button).
Verified on FF38(Android 4.2.1). Issue is also reproducing on FF OS 1.4 (Inari). Not reproducing on desktop.

Comment 1

[Kevin Ngo [:ngoke]]

Here's an attempt: https://github.com/mozilla/fireplace/commit/47e3017b9c420bc2a8afeaf835de9aca226d6a04

If it still fails, can you send me Ashes? Thanks!

Comment 2

[Valentina Virlics [:vvalentina], Ecosystem QA]

Verified as fixed on FF38(Android 4.2.1) and FFOS 1.4(Inari).
Closing bug.

Comment 3

[Valentina Virlics [:vvalentina], Ecosystem QA]

This issue is now reproducing on MP-dev on FF38(Win 7).
Please see screencast http://screencast.com/t/R2wY3ZITGgc

Comment 4

[Valentina Virlics [:vvalentina], Ecosystem QA]

(In reply to Kevin Ngo [:ngoke] from comment #1)
> Here's an attempt:
> https://github.com/mozilla/fireplace/commit/
> 47e3017b9c420bc2a8afeaf835de9aca226d6a04
> 
> If it still fails, can you send me Ashes? Thanks!

Sorry, I forgot Ashes - ID: 0e8ab for comment #3.

Comment 5

[Kevin Ngo [:ngoke]]

It looked like it worked in the screencast, and it's still working for me.

The ashes say the review was not found. Was it possible it was deleted while you were reviewing?

Comment 6

[Valentina Virlics [:vvalentina], Ecosystem QA]

(In reply to Kevin Ngo [:ngoke] from comment #5)
> It looked like it worked in the screencast, and it's still working for me.
> The ashes say the review was not found. Was it possible it was deleted while
> you were reviewing?

There is a small issue in what concerns deleting a review...the review does not disappear if user leaves the page and comes back, just after refresh, and maybe that was the problem. Please see screencast - http://screencast.com/t/MJkgcvk6n - and let me know if should i file another bug?

Verified as fixed on MP-dev FF38 (Win 7)
Postfix screencast http://screencast.com/t/m0o95oOm

Comment 7

[Kevin Ngo [:ngoke]]

Okay. That was probably it. Can you file another bug with that STR? Delete review, go back, try to edit it.

Just need to bust the cache.

Comment 8

[Valentina Virlics [:vvalentina], Ecosystem QA]

(In reply to Kevin Ngo [:ngoke] from comment #7)
> Okay. That was probably it. Can you file another bug with that STR? Delete
> review, go back, try to edit it.
> 
> Just need to bust the cache.

Will file another bug.
Closing this one.