Closed
Bug 1128953
Opened 9 years ago
Closed 9 years ago
Rename win64 FTP directory
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox36 fixed, firefox37 fixed, firefox38 fixed)
RESOLVED
FIXED
mozilla38
People
(Reporter: rail, Assigned: rail)
References
Details
Attachments
(3 files)
884 bytes,
patch
|
mshal
:
review+
lmandel
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
1.57 KB,
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
952 bytes,
patch
|
bhearsum
:
review+
|
Details | Diff | Splinter Review |
Windows 64 builds use "win64-x86_64" when they upload files to FTP. This is misaligned with "win32", adds some confusion, and requires extra platform-to-FTP-name mappings. It would be great to unify the names and use just "win64". Testing the patch.
Assignee | ||
Updated•9 years ago
|
Blocks: win64-release
Assignee | ||
Comment 1•9 years ago
|
||
Comment on attachment 8558525 [details] [diff] [review] win64.diff This worked fine for a staging release. Another patch for buildbotcustom incoming.
Attachment #8558525 -
Flags: review?(mshal)
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8559131 -
Flags: review?(mshal)
Assignee | ||
Comment 3•9 years ago
|
||
FTR, it'd be great to land the build system patch at the same time to mozilla-central and mozilla-aurora.
Comment 4•9 years ago
|
||
Comment on attachment 8558525 [details] [diff] [review] win64.diff Looks good to me!
Attachment #8558525 -
Flags: review?(mshal) → review+
Updated•9 years ago
|
Attachment #8559131 -
Flags: review?(mshal) → review+
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8558525 [details] [diff] [review] win64.diff Releng needs this patch for win64 automation. It would be great to land this patch to mozilla-central and mozilla-aurora in the same day to minimize the risk of broken aurora nigthly builds. [Feature/regressing bug #]: - [User impact if declined]: The only change will be the name of the package in nightly directories. The platform is not a tier 1 platform, so the impact should be minimal. [Describe test coverage new/current, TreeHerder]: Passed a staging release [Risks and why]: Not expected [String/UUID change made/needed]: None
Attachment #8558525 -
Flags: approval-mozilla-aurora?
Comment 6•9 years ago
|
||
Comment on attachment 8558525 [details] [diff] [review] win64.diff I think you're right to make this change before we start pushing to get more users on these builds. As we already have Nightly users on Win64 builds, will this change impact them? If so, how can we get information out to them so that they know what to expect. (To be clear, I don't think this should block us from proceeding.) Aurora+
Attachment #8558525 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 7•9 years ago
|
||
This will be transparent for the existing users. Balrog will use the new paths automagically.
Assignee | ||
Comment 8•9 years ago
|
||
http://nightly.mozilla.org/ will need to update the links
Assignee | ||
Comment 9•9 years ago
|
||
Comment on attachment 8558525 [details] [diff] [review] win64.diff https://hg.mozilla.org/integration/mozilla-inbound/rev/921109cf8981
Attachment #8558525 -
Flags: checkin+
Assignee | ||
Comment 10•9 years ago
|
||
Comment on attachment 8559131 [details] [diff] [review] custom.diff https://hg.mozilla.org/build/buildbotcustom/rev/9fc99ca28c3f
Attachment #8559131 -
Flags: checkin+
Comment 11•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/921109cf8981 I'll queue this up for Aurora shortly.
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox38:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Comment 12•9 years ago
|
||
In production: https://hg.mozilla.org/build/buildbotcustom/rev/9fc99ca28c3f
Comment 13•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/1880b489e2bf
status-firefox37:
--- → fixed
Comment 14•9 years ago
|
||
Inconveniently, we build win64 on mozilla-beta, and that's what we run win8 tests on, and since the in-tree part didn't land on beta, now the builds are broken and the tests can't run. mozilla-beta is closed.
Severity: normal → blocker
Status: RESOLVED → REOPENED
status-firefox36:
--- → affected
Resolution: FIXED → ---
Assignee | ||
Comment 15•9 years ago
|
||
This should cover all branches. I'm not touching the complete MAR pattern because we don't generate nightly builds on beta.
Attachment #8559580 -
Flags: review?(bhearsum)
Comment 16•9 years ago
|
||
I don't see why we should be running win64 on beta at this point if we're not releasing it until next cycle.
Comment 17•9 years ago
|
||
Comment on attachment 8559580 [details] [diff] [review] win64_glob.diff Review of attachment 8559580 [details] [diff] [review]: ----------------------------------------------------------------- lame
Attachment #8559580 -
Flags: review?(bhearsum) → review+
Assignee | ||
Comment 18•9 years ago
|
||
Comment on attachment 8559580 [details] [diff] [review] win64_glob.diff https://hg.mozilla.org/build/buildbotcustom/rev/18a5578d0600
Attachment #8559580 -
Flags: checkin+
Assignee | ||
Comment 19•9 years ago
|
||
In production: https://hg.mozilla.org/build/buildbotcustom/rev/18a5578d0600
Comment 20•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/e7fd0d7ff120 I've gone ahead and uplifted the fix for now to get the tree reopened. Feel free to turn the builds off if you want.
Comment 21•9 years ago
|
||
This change broke our Mozmill CI and especially mozdownload, which is not able to download this build anymore. I have a fix for that but before releasing it I would like to know that we indeed keep this change for the future.
Flags: needinfo?(rail)
Comment 22•9 years ago
|
||
(In reply to Henrik Skupin (:whimboo) from comment #21) > This change broke our Mozmill CI and especially mozdownload, which is not > able to download this build anymore. I have a fix for that but before > releasing it I would like to know that we indeed keep this change for the > future. Yes, we're keeping this change.
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(rail)
Assignee | ||
Updated•9 years ago
|
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Comment 23•9 years ago
|
||
:rail There are still x86_64 files from February 4th in the latest-trunk/ and latest-mozilla-(aurora|central)/ directories (and possibly in others too). Do they have to be removed manually? Also, in latest-mozilla-aurora-l10n/, there's an empty win64-x86_64/ directory.
Flags: needinfo?(rail)
Assignee | ||
Comment 24•9 years ago
|
||
I'll forward this to Nick, he may know this.
Flags: needinfo?(rail) → needinfo?(nthomas)
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•