Closed
Bug 1128986
Opened 9 years ago
Closed 9 years ago
Mulet reftest not working because of TypeError system is undefined
Categories
(Firefox OS Graveyard :: Runtime, defect)
Tracking
(firefox38 fixed)
RESOLVED
FIXED
2.2 S6 (20feb)
Tracking | Status | |
---|---|---|
firefox38 | --- | fixed |
People
(Reporter: gerard-majax, Assigned: gerard-majax)
References
Details
(Whiteboard: [systemsfe])
Attachments
(1 file)
3.57 KB,
patch
|
jgriffin
:
review+
|
Details | Diff | Splinter Review |
> marionette.errors.JavascriptException: JavascriptException: TypeError: system is undefined https://treeherder.mozilla.org/#/jobs?repo=try&revision=489ec085db6b&exclusion_state=all
Assignee | ||
Comment 1•9 years ago
|
||
Trying to update gaia_lock_screen.js: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f7a6c38dc869
Assignee | ||
Comment 2•9 years ago
|
||
(In reply to Alexandre LISSY :gerard-majax from comment #1) > Trying to update gaia_lock_screen.js: > https://treeherder.mozilla.org/#/jobs?repo=try&revision=f7a6c38dc869 According to this try, then just updating this bit makes the tests at least run and we are back to the state where there's a lot of failures :)
Assignee | ||
Comment 3•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8558639 -
Flags: review?(jonas)
Updated•9 years ago
|
Whiteboard: [systemsfe]
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8558639 [details] [diff] [review] Update gaia_lock_screen.js r=sicking Vivien, do you mind reviewing this ? It's just a copy of a gaia file that is not uptodate.
Attachment #8558639 -
Flags: review?(jonas) → review?(21)
Assignee | ||
Updated•9 years ago
|
Attachment #8558639 -
Flags: review?(21) → review?(jgriffin)
Comment 5•9 years ago
|
||
Comment on attachment 8558639 [details] [diff] [review] Update gaia_lock_screen.js r=sicking Review of attachment 8558639 [details] [diff] [review]: ----------------------------------------------------------------- Thanks.
Attachment #8558639 -
Flags: review?(jgriffin) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 6•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4dc281028140
Keywords: checkin-needed
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4dc281028140
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox38:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S6 (20feb)
You need to log in
before you can comment on or make changes to this bug.
Description
•