Closed Bug 1128991 Opened 5 years ago Closed 5 years ago

[mobile] Update filter.py to ignore US specific keys in region.properties

Categories

(Firefox Build System :: Android Studio and Gradle Integration, defect)

defect
Not set

Tracking

(firefox36 fixed, firefox37 fixed, firefox38 fixed)

RESOLVED FIXED
mozilla38
Tracking Status
firefox36 --- fixed
firefox37 --- fixed
firefox38 --- fixed

People

(Reporter: flod, Assigned: flod)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 1117186 introduces 4 new keys in region.properties, but these are needed only for en-US.

browser.search.defaultenginename.US
browser.search.order.US.1
browser.search.order.US.2
browser.search.order.US.3

These new keys are currently reported as missing by compare-locales, asking localizers to add them.
Attached patch bug1128991.patch (obsolete) — Splinter Review
I assume it's safe to ignore browser.search.*.US
Attachment #8558583 - Flags: review?(mark.finkle)
Actually switching to something different than .*
Attachment #8558583 - Attachment is obsolete: true
Attachment #8558583 - Flags: review?(mark.finkle)
Attachment #8558592 - Flags: review?(mark.finkle)
Comment on attachment 8558592 [details] [diff] [review]
bug1128991v1.patch

LGTM. Thanks!
Attachment #8558592 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/ff6d8e6788bd
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
Comment on attachment 8558592 [details] [diff] [review]
bug1128991v1.patch

Approval Request Comment
[Feature/regressing bug #]: bug 1117186
[User impact if declined]: Bad for l10n people
[Describe test coverage new/current, TreeHerder]: Working OK on Nightly
[Risks and why]: Low, only filters stuff from l10n
[String/UUID change made/needed]: none
Attachment #8558592 - Flags: approval-mozilla-beta?
Attachment #8558592 - Flags: approval-mozilla-aurora?
Attachment #8558592 - Flags: approval-mozilla-beta?
Attachment #8558592 - Flags: approval-mozilla-beta+
Attachment #8558592 - Flags: approval-mozilla-aurora?
Attachment #8558592 - Flags: approval-mozilla-aurora+
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 38 → mozilla38
You need to log in before you can comment on or make changes to this bug.