1128991 - [mobile] Update filter.py to ignore US specific keys in region.properties

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[Francesco Lodolo [:flod]]

Bug 1117186 introduces 4 new keys in region.properties, but these are needed only for en-US.

browser.search.defaultenginename.US
browser.search.order.US.1
browser.search.order.US.2
browser.search.order.US.3

These new keys are currently reported as missing by compare-locales, asking localizers to add them.

Comment 1

[Francesco Lodolo [:flod]]

Attachment: bug1128991.patch

I assume it's safe to ignore browser.search.*.US

Comment 2

[Francesco Lodolo [:flod]]

Attachment: bug1128991v1.patch

Actually switching to something different than .*

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8558592 [details] [diff] [review]
bug1128991v1.patch

LGTM. Thanks!

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/ff6d8e6788bd

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ff6d8e6788bd

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8558592 [details] [diff] [review]
bug1128991v1.patch

Approval Request Comment
[Feature/regressing bug #]: bug 1117186
[User impact if declined]: Bad for l10n people
[Describe test coverage new/current, TreeHerder]: Working OK on Nightly
[Risks and why]: Low, only filters stuff from l10n
[String/UUID change made/needed]: none

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5754ca42b8d3

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3bf30338bcbe