1129042 - [Loop][Telemetry] "numberTimesIJoined" isn't reporting correctly.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Loli (:lolimartinezcr)]

Fire E 2.0
Loop 1.1.1/d4d66d37

Prerequistes:
User A logged in Mobile Loop application.
User A has 2 rooms owner and 1 invited room in room list.
Period of time between telemetry traces (1 min)

STRs:
1. User A taps on invited room.
2. User A leaves on invited room.
3. User A taps on invited room.
4. User A leaves on invited room.

Expected result:
Hope telemetry trace
 Telemetry trace is:
"numberTimesIJoined":{"0":2,"2":1}

Actual result:
Hope telemetry trace
 Telemetry trace is:
"numberTimesIJoined":{"0":3}

Comment 1

[Carmen Jimenez Cabezas]

This count is not going to be correct in all cases because when a room is used in two mobiles (owner and peer-another user) we're going to count two visits to the room, but when the room is used by a mobile user and a desktop user we will count only one visit to the room. 
This was why we agreed with products guys we're only going to count owners join in each phone.
Anyway I'll wait for product team

Comment 2

[Carmen Jimenez Cabezas]

Attachment: V1 Proposed patch

After we talked with products team, let's count joins both owner and guest room

Comment 3

[Antonio Manuel Amaya Calvo (:amac)]

Comment on attachment 8559232 [details] [review]
V1 Proposed patch

LGTM, thank you!

Comment 4

[Carmen Jimenez Cabezas]

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/065b2aed8e84b27d518b46996d5ed171ab1488b6

Comment 5

[Maria Angeles Oteo (:oteo)]

Carmen, please, can you uplift the patch to 1.1.1 branch?

Thanks a lot!

Comment 6

[Carmen Jimenez Cabezas]

Uplift commit:
https://github.com/mozilla-b2g/firefoxos-loop-client/commit/ebe4a8d9e7e3eec400ee4717ea62796ea01f7a37

Comment 7

[Javier de Prado]

Verified on fireE, v2.0 comercial version.
Loop version 1.1.1/253ebde