1129075 - [RTL][Camera] When attaching image from Camera only half of the image is shown in image preview while using RTL language

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect, P1)

Description

[Brogan Zumwalt [Inactive]]

Attachment: Screenshot

Description:
When attaching image from Camera in Email, Messages, or Contacts apps, the image preview only shows half of the image. Only the right half of the image is shown, with the left half off of the screen. Where the right half of the image should be positioned, the screen is black. The image itself is taken correctly, and will send correctly if accepted, it is only the image preview that is affected.

Repro Steps:
1) Update a Flame to 20150203055641
2) Launch Messages app
3) Create new message thread and tap attach icon
4) Select Camera from list
5) Take picture

Actual:
The left half of the image is off the screen and only the right half of the image is visible in the image preview after taking picture.

Expected:
The entire picture is visible in image preview.

Environmental Variables:
Device: Flame 3.0
Build ID: 20150203055641
Gaia: ae5a1580da948c3b9f93528146b007fc4f6a712b
Gecko: ae5d04409cd9
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Repro frequency: 3/3, 100%
See attached: screenshot & logcat

Comment 1

[Brogan Zumwalt [Inactive]]

Attachment: Logcat

Comment 2

[Brogan Zumwalt [Inactive]]

Corrected steps to reproduce:

Steps must be performed while language is set to Arabic.

Repro Steps:
1) Update a Flame to 20150203055641
2) Set language to Arabic
3) Launch Messages app
4) Create new message thread and tap attach icon
5) Select Camera from list
6) Take picture


Video of issue: http://youtu.be/3GIqbafrkKY


Issue DOES reproduce on Flame 2.2

The left half of the image is off the screen and only the right half of the image is visible in the image preview after taking picture.

Device: Flame 2.2
Build ID: 20150203002504
Gaia: cd62ff9fe199fb43920ba27bd5fdbc5c311016fc
Gecko: 11d93135c678
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 3

[KTucker [:KTucker][Inactive 3/4/2016]]

Nominating this 2.2? since the user can only see half of the picture preview.

Comment 4

[Hema Koka [:hema]]

Blocking Reason: Preview is messed up with only partial image seen.

Diego, please fix this! Assigning to you.

Thanks
Hema

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] dmarcos:bug1129075 > mozilla-b2g:v2.2

Comment 6

[Diego Marcos [:dmarcos]]

Attachment: Pull Request

.confirm-media-frame > img style in confirm.css is outdated since MediaFrame doesn't use an img element anymore (change made in bug 1068986). It now uses a background-image to display photos. The style above is not applied and the global rule "direction: rtl" is inherited making the positioning calculations of MediaFrame incorrect (done in setPosition in media_frame.js)

Comment 7

[David Flanagan [:djf]]

Comment on attachment 8562893 [details] [review]
Pull Request

r+ Please request uplift for this as well.

Punam fixed this issue for the camera preview gallery in bug 1087058, but missed this confirm case.

Comment 8

[David Flanagan [:djf]]

Actually, I just noticed that you only have a PR to fix this on 2.2. It also needs to be fixed on master, doesn't it?

Comment 9

[GitHub Autolander Bot]

Attachment: [gaia] dmarcos:bug1129075-master > mozilla-b2g:master

Comment 10

[Diego Marcos [:dmarcos]]

Same patch applies on master

Comment 11

[Diego Marcos [:dmarcos]]

Landed on 2.2:

https://github.com/mozilla-b2g/gaia/commit/791e53728cd8018f1d7cf7efe06bbeb1179f0370

Comment 12

[Diego Marcos [:dmarcos]]

Landed on master:

https://github.com/mozilla-b2g/gaia/pull/28154

Comment 13

[Diego Marcos [:dmarcos]]

(In reply to Diego Marcos [:dmarcos] from comment #12)
> Landed on master:
> 
> https://github.com/mozilla-b2g/gaia/pull/28154

https://github.com/mozilla-b2g/gaia/commit/1166ea84708b2e0b500167a8a716eaab896132dc

Comment 14

[Brogan Zumwalt [Inactive]]

Comment on attachment 8562893 [details] [review]
Pull Request

Patch works great. On today's unmodified Flame 2.2 and 3.0 the issue still occurs, but when your gaia change is applied (manually applied to gaia repo before you landed) the issue no longer reproduces.

When taking a picture from camera to attach to MMS, the preview is centered and no part is cut off while language is set to Arabic.

Device: Flame 2.2
Build ID: 20150211002505
Gaia: ca726d8f4136596adce98ae5dd2498389c3823cf
Gecko: e614443583e7
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Device: Flame 3.0
Build ID: 20150211010216
Gaia: 30b7c18fc00e55485d0beef01a6f08d0042c89a5
Gecko: ee093ca70666
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Per the Landing Policy, all patches require approval to land on v2.2. Why wasn't it followed here?
https://wiki.mozilla.org/Release_Management/B2G_Landing#Landing_Procedure_6

Comment 16

[Diego Marcos [:dmarcos]]

It's a P1 2.2+ blocker that is one line CSS change so I assumed it was ok. The changed was requested by Hema Koka, reviewed by David Flanagan and confirmed that fixed the issue by QA.

Comment 17

[bhavana bajaj [:bajaj]]

(In reply to Diego Marcos [:dmarcos] from comment #16)
> It's a P1 2.2+ blocker that is one line CSS change so I assumed it was ok.
> The changed was requested by Hema Koka, reviewed by David Flanagan and
> confirmed that fixed the issue by QA.

Nevertheless, should have gone through approval.

Comment 18

[Coler]

This issue has been verified successfully on Flame 2.2/3.0.
Reproduce rate:0/5.
Attachment:Verify_RTL_Camera.png

Flame 3.0 build:

Build ID               20150214010227
Gaia Revision          f0b93e0668ef9565bd6f050b15b4f794d59feb65
Gaia Date              2015-02-13 13:13:27
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/a7c177546ca0
Gecko Version          38.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150214.043959
Firmware Date          Sat Feb 14 04:40:10 EST 2015
Bootloader             L1TC000118D0


Flame 2.2:

Build ID               20150214002504
Gaia Revision          ea64caf6d4ab03fc4472eca9f41f20d651d55fa9
Gaia Date              2015-02-13 05:27:43
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/6de30e6bbc84
Gecko Version          37.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150214.044811
Firmware Date          Sat Feb 14 04:48:22 EST 2015
Bootloader             L1TC000118D0

Comment 19

[Coler]

Attachment: Verify_RTL_Camera.png

Comment 20

[Alissa（leave from Mozilla）]

Test case has been added in moztrap:

https://moztrap.mozilla.org/manage/case/15923/