Closed Bug 1129091 Opened 9 years ago Closed 6 years ago

Intermittent history_000.htm | history.pushState accepts a third parameter 'url' and uses it to alter location

Categories

(Core :: DOM: Navigation, defect)

Product:
Core
Component:
DOM: Navigation
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla62
Tracking Flags:
Tracking Status
firefox62 --- fixed

People

(Reporter: RyanVM, Assigned: kats)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell fixed:timing][wptsync upstream])

Attachments

(1 file)

Bug 1129091 - Wait for the iframes to load before running test functions that use them.
59 bytes, text/x-review-board-request
jgraham
: review+
Details 
06:08:50 INFO - TEST-PASS | /old-tests/submission/Microsoft/history/history_000.htm | history.pushState is present
06:08:50 INFO - TEST-PASS | /old-tests/submission/Microsoft/history/history_000.htm | history.replaceState is present
06:08:50 INFO - TEST-PASS | /old-tests/submission/Microsoft/history/history_000.htm | history.state is present
06:08:50 INFO - TEST-PASS | /old-tests/submission/Microsoft/history/history_000.htm | history.state is initialized to null
06:08:50 INFO - TEST-PASS | /old-tests/submission/Microsoft/history/history_000.htm | history.pushState increments history.length
06:08:50 INFO - TEST-PASS | /old-tests/submission/Microsoft/history/history_000.htm | history.pushState clears forward entries
06:08:50 INFO - TEST-UNEXPECTED-FAIL | /old-tests/submission/Microsoft/history/history_000.htm | history.pushState accepts a third parameter 'url' and uses it to alter location - (stack: testCollection</<@http://web-platform.test:8000/old-tests/submission/Microsoft/history/history_000.htm:94:24
06:08:50 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1189:19
06:08:50 INFO - test@http://web-platform.test:8000/resources/testharness.js:428:8
06:08:50 INFO - testCollection<@http://web-platform.test:8000/old-tests/submission/Microsoft/history/history_000.htm:93:0
06:08:50 INFO - )
06:08:50 INFO - TEST-UNEXPECTED-FAIL | /old-tests/submission/Microsoft/history/history_000.htm | history.pushState's url parameter can be an absolute url - (stack: testCollection</<@http://web-platform.test:8000/old-tests/submission/Microsoft/history/history_000.htm:105:24
06:08:50 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1189:19
06:08:50 INFO - test@http://web-platform.test:8000/resources/testharness.js:428:8
06:08:50 INFO - testCollection<@http://web-platform.test:8000/old-tests/submission/Microsoft/history/history_000.htm:99:0
06:08:50 INFO - )
06:08:50 INFO - TEST-UNEXPECTED-FAIL | /old-tests/submission/Microsoft/history/history_000.htm | history.pushState can modify location object in multiple frames - (stack: testCollection</<@http://web-platform.test:8000/old-tests/submission/Microsoft/history/history_000.htm:112:24
06:08:50 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1189:19
06:08:50 INFO - test@http://web-platform.test:8000/resources/testharness.js:428:8
06:08:50 INFO - testCollection<@http://web-platform.test:8000/old-tests/submission/Microsoft/history/history_000.htm:111:0
06:08:50 INFO - )
06:08:50 INFO - TEST-UNEXPECTED-FAIL | /old-tests/submission/Microsoft/history/history_000.htm | history.pushState throws DOMException with code SECURITY_ERR (18) - assert_throws: Security_Err 18 should be thrown function "function () { history.pushState(null, null, testurl); }" threw object "[Exception... "Failure" nsresult: "0x80004005 (NS_ERROR_..." that is not a DOMException SECURITY_ERR: property "code" is equal to undefined, expected 18
06:08:50 INFO - TEST-PASS | /old-tests/submission/Microsoft/history/history_000.htm | history.pushState throws DATA_CLONE_ERR(25) for bad state parameter
06:08:50 INFO - TEST-PASS | /old-tests/submission/Microsoft/history/history_000.htm | history.replaceState does not increment history.length
06:08:50 INFO - TEST-PASS | /old-tests/submission/Microsoft/history/history_000.htm | history.replaceState does not clear forward entries
06:08:50 INFO - TEST-UNEXPECTED-FAIL | /old-tests/submission/Microsoft/history/history_000.htm | history.replaceState accepts a third parameter 'url' and uses it to alter location - (stack: testCollection</<@http://web-platform.test:8000/old-tests/submission/Microsoft/history/history_000.htm:173:24
06:08:50 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1189:19
06:08:50 INFO - test@http://web-platform.test:8000/resources/testharness.js:428:8
06:08:50 INFO - testCollection<@http://web-platform.test:8000/old-tests/submission/Microsoft/history/history_000.htm:172:0
06:08:50 INFO - )
06:08:50 INFO - TEST-UNEXPECTED-FAIL | /old-tests/submission/Microsoft/history/history_000.htm | history.replaceState's url parameter can be an absolute url - (stack: testCollection</<@http://web-platform.test:8000/old-tests/submission/Microsoft/history/history_000.htm:184:24
06:08:50 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1189:19
06:08:50 INFO - test@http://web-platform.test:8000/resources/testharness.js:428:8
06:08:50 INFO - testCollection<@http://web-platform.test:8000/old-tests/submission/Microsoft/history/history_000.htm:178:0
06:08:50 INFO - )
06:08:50 INFO - TEST-UNEXPECTED-FAIL | /old-tests/submission/Microsoft/history/history_000.htm | history.replaceState can modify location object in multiple frames - (stack: testCollection</<@http://web-platform.test:8000/old-tests/submission/Microsoft/history/history_000.htm:191:24
06:08:50 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1189:19
06:08:50 INFO - test@http://web-platform.test:8000/resources/testharness.js:428:8
06:08:50 INFO - testCollection<@http://web-platform.test:8000/old-tests/submission/Microsoft/history/history_000.htm:190:0
06:08:50 INFO - )
[Mass Closure] Closing Intermittent as a one off
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Component: Places → Document Navigation
Product: Toolkit → Core
Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.
Priority: -- → P3
Priority: P3 → P5
this has increased in frequency the last week, not enough to track via stockwell, but maybe if it remains high we will look into it more.
There are 40 failures in the last 7 days
 - 35 failures on Linux x64Quantum Render debug
 - 1 failure on OS X 10.10 debug 
 - 4 failures on Windows10-64-ccov
 Example failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=177764311&repo=mozilla-inbound&lineNumber=21843

[task 2018-05-09T23:39:51.479Z] 23:39:51     INFO - TEST-START | /old-tests/submission/Microsoft/history/history_000.htm
[task 2018-05-09T23:39:51.668Z] 23:39:51     INFO - PID 10855 | ++DOMWINDOW == 18 (0x7f88f1ee1400) [pid = 10921] [serial = 18] [outer = 0x7f890d29ae00]
[task 2018-05-09T23:39:52.019Z] 23:39:52     INFO - PID 10855 | [Parent 10855, Main Thread] WARNING: NS_ENSURE_TRUE(aSecondURI) failed: file /builds/worker/workspace/build/src/dom/base/ThirdPartyUtil.cpp, line 98
[task 2018-05-09T23:39:52.260Z] 23:39:52     INFO - PID 10855 | [GFX1-]: Unknown pipeline used for iframe IframeDisplayItem { clip_id: Clip(4, PipelineId(1, 1)), pipeline_id: PipelineId(1, 6) }
[task 2018-05-09T23:39:52.260Z] 23:39:52     INFO - PID 10855 | ERROR 2018-05-09T23:39:52Z: webrender::display_list_flattener: Unknown pipeline used for iframe IframeDisplayItem { clip_id: Clip(4, PipelineId(1, 1)), pipeline_id: PipelineId(1, 6) }
[task 2018-05-09T23:39:52.342Z] 23:39:52     INFO - PID 10855 | ++DOCSHELL 0x7f88eb14b000 == 4 [pid = 10921] [id = {0c7f6cb7-61e0-4c56-b90d-1871e38a17b9}]
[task 2018-05-09T23:39:52.343Z] 23:39:52     INFO - PID 10855 | ++DOMWINDOW == 19 (0x7f88eb1c0400) [pid = 10921] [serial = 19] [outer = (nil)]
[task 2018-05-09T23:39:52.404Z] 23:39:52     INFO - PID 10855 | ++DOMWINDOW == 20 (0x7f88eb1d1c00) [pid = 10921] [serial = 20] [outer = 0x7f88eb1c0400]
[task 2018-05-09T23:39:52.561Z] 23:39:52     INFO - PID 10855 | ++DOMWINDOW == 21 (0x7f88eb1d0800) [pid = 10921] [serial = 21] [outer = 0x7f88eb1c0400]
[task 2018-05-09T23:39:52.946Z] 23:39:52     INFO - PID 10855 | ++DOCSHELL 0x7f88eda28800 == 5 [pid = 10921] [id = {2d2ba240-9951-47df-b81a-46953b6592f2}]
[task 2018-05-09T23:39:52.948Z] 23:39:52     INFO - PID 10855 | ++DOMWINDOW == 22 (0x7f88ee04ce00) [pid = 10921] [serial = 22] [outer = (nil)]
[task 2018-05-09T23:39:52.950Z] 23:39:52     INFO - PID 10855 | ++DOCSHELL 0x7f88f3bc0800 == 6 [pid = 10921] [id = {031674d7-23aa-48df-bf76-3f4cdc4eeace}]
[task 2018-05-09T23:39:52.950Z] 23:39:52     INFO - PID 10855 | ++DOMWINDOW == 23 (0x7f88ee04d000) [pid = 10921] [serial = 23] [outer = (nil)]
[task 2018-05-09T23:39:53.463Z] 23:39:53     INFO - PID 10855 | ++DOMWINDOW == 24 (0x7f88f6d0ec00) [pid = 10921] [serial = 24] [outer = 0x7f88ee04ce00]
[task 2018-05-09T23:39:53.479Z] 23:39:53     INFO - PID 10855 | [Child 10921, Main Thread] WARNING: NS_ENSURE_SUCCESS(currentURI->GetUserPass(currentUserPass), NS_ERROR_FAILURE) failed with result 0x80004005: file /builds/worker/workspace/build/src/docshell/base/nsDocShell.cpp, line 11777
[task 2018-05-09T23:39:53.536Z] 23:39:53     INFO - PID 10855 | [Child 10921, Main Thread] WARNING: NS_ENSURE_SUCCESS(currentURI->GetUserPass(currentUserPass), NS_ERROR_FAILURE) failed with result 0x80004005: file /builds/worker/workspace/build/src/docshell/base/nsDocShell.cpp, line 11777
[task 2018-05-09T23:39:53.597Z] 23:39:53     INFO - PID 10855 | [Child 10921, Main Thread] WARNING: NS_ENSURE_SUCCESS(currentURI->GetUserPass(currentUserPass), NS_ERROR_FAILURE) failed with result 0x80004005: file /builds/worker/workspace/build/src/docshell/base/nsDocShell.cpp, line 11777
[task 2018-05-09T23:39:53.626Z] 23:39:53     INFO - PID 10855 | ++DOMWINDOW == 25 (0x7f88f6d12c00) [pid = 10921] [serial = 25] [outer = 0x7f88ee04d000]
[task 2018-05-09T23:39:53.715Z] 23:39:53     INFO - PID 10855 | [Child 10921, Main Thread] WARNING: 'aRv.Failed()', file /builds/worker/workspace/build/src/dom/ipc/StructuredCloneData.cpp, line 123
[task 2018-05-09T23:39:53.716Z] 23:39:53     INFO - PID 10855 | [Child 10921, Main Thread] WARNING: 'rv.Failed()', file /builds/worker/workspace/build/src/dom/base/nsStructuredCloneContainer.cpp, line 51
[task 2018-05-09T23:39:53.718Z] 23:39:53     INFO - PID 10855 | [Child 10921, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80530019: file /builds/worker/workspace/build/src/docshell/base/nsDocShell.cpp, line 11698
[task 2018-05-09T23:39:53.718Z] 23:39:53     INFO - PID 10855 | [Parent 10855, Main Thread] WARNING: NS_ENSURE_TRUE(aSecondURI) failed: file /builds/worker/workspace/build/src/dom/base/ThirdPartyUtil.cpp, line 98
[task 2018-05-09T23:39:54.169Z] 23:39:54     INFO - PID 10855 | [Child 10921, Main Thread] WARNING: 'aRv.Failed()', file /builds/worker/workspace/build/src/dom/ipc/StructuredCloneData.cpp, line 123
[task 2018-05-09T23:39:54.170Z] 23:39:54     INFO - PID 10855 | [Child 10921, Main Thread] WARNING: 'rv.Failed()', file /builds/worker/workspace/build/src/dom/base/nsStructuredCloneContainer.cpp, line 51
[task 2018-05-09T23:39:54.170Z] 23:39:54     INFO - PID 10855 | [Child 10921, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80530019: file /builds/worker/workspace/build/src/docshell/base/nsDocShell.cpp, line 11698
[task 2018-05-09T23:39:54.746Z] 23:39:54     INFO - 
[task 2018-05-09T23:39:54.747Z] 23:39:54     INFO - TEST-PASS | /old-tests/submission/Microsoft/history/history_000.htm | onpopstate in window 
[task 2018-05-09T23:39:54.747Z] 23:39:54     INFO - TEST-PASS | /old-tests/submission/Microsoft/history/history_000.htm | history.pushState is present 
[task 2018-05-09T23:39:54.748Z] 23:39:54     INFO - TEST-PASS | /old-tests/submission/Microsoft/history/history_000.htm | history.replaceState is present 
[task 2018-05-09T23:39:54.749Z] 23:39:54     INFO - TEST-PASS | /old-tests/submission/Microsoft/history/history_000.htm | history.state is present 
[task 2018-05-09T23:39:54.750Z] 23:39:54     INFO - TEST-PASS | /old-tests/submission/Microsoft/history/history_000.htm | history.state is initialized to null 
[task 2018-05-09T23:39:54.750Z] 23:39:54     INFO - TEST-PASS | /old-tests/submission/Microsoft/history/history_000.htm | history.pushState increments history.length 
[task 2018-05-09T23:39:54.750Z] 23:39:54     INFO - TEST-PASS | /old-tests/submission/Microsoft/history/history_000.htm | history.pushState clears forward entries 
[task 2018-05-09T23:39:54.751Z] 23:39:54     INFO - TEST-UNEXPECTED-FAIL | /old-tests/submission/Microsoft/history/history_000.htm | history.pushState accepts a third parameter 'url' and uses it to alter location -
Flags: needinfo?(overholt)
Whiteboard: [stockwell unknown] → [stockwell unknown][stockwell needswork:owner]
:kats, this is a linux-qr failure only, can you take a look at this?
Flags: needinfo?(bugmail)
Looks like the line at https://searchfox.org/mozilla-central/rev/a85db9e29eb3f022dbaf8b9a6390ecbacf51e7dd/testing/web-platform/tests/old-tests/submission/Microsoft/history/history_000.htm#94 is throwing some sort of an exception, maybe? The failure log points to line 94 as opposed to the assert_equals in line 95, but there's no detailed error message as to what went wrong. I'm guessing that at the point the test runs the iframe hasn't loaded yet and so the pushState doesn't work properly. This would explain why the test was failing intermittently even before WebRender came along; WebRender just made it slower so it fails more frequently.

I'll see if I can reproduce it locally and write a patch for it.
Is there an equivalent of SimpleTest.requestCompleteLog() for web-platform-tests?
Flags: needinfo?(bugmail) → needinfo?(jmaher)
I really don't know, :jgraham would know!
Flags: needinfo?(jmaher) → needinfo?(james)
Flags: needinfo?(overholt)
No; all the logging we have is in the raw log e.g. https://taskcluster-artifacts.net/MnX7n-PSThKWw-p3UP-l_Q/0/public/test_info//wpt_raw.log but I don't think there's anything useful there that's not in the formatted log.
Flags: needinfo?(james)
So how is one supposed to debug failures that can't be reproduced locally?
Flags: needinfo?(james)
Comment on attachment 8975789 [details]
Bug 1129091 - Wait for the iframes to load before running test functions that use them.

https://reviewboard.mozilla.org/r/243994/#review249924

Thanks!
Attachment #8975789 - Flags: review?(james) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0c4678b5ea53
Wait for the iframes to load before running test functions that use them. r=jgraham
Created web-platform-tests PR https://github.com/w3c/web-platform-tests/pull/11008 for changes under testing/web-platform/tests
Whiteboard: [stockwell unknown][stockwell needswork:owner] → [stockwell unknown][stockwell needswork:owner][wptsync upstream]
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
https://hg.mozilla.org/mozilla-central/rev/0c4678b5ea53
Status: REOPENED → RESOLVED
Closed: 9 years ago → 6 years ago
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Assignee: nobody → bugmail
If there are specific pieces of logging you would like that aren't currently avaiable in web-platform-tests, file a new bug and we can figure out how to make it work.
Flags: needinfo?(james)
Whiteboard: [stockwell unknown][stockwell needswork:owner][wptsync upstream] → [stockwell fixed:timing][wptsync upstream]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: