[Error: ics-service doesn't recognize own tzid: floating] [TypeError: aComponent is null] in calTimezoneService.js

RESOLVED FIXED in 4.0.0.1

Status

Calendar
Internal Components
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Stefan Sitter, Assigned: darktrojan)

Tracking

Lightning 4.0.0.1
4.0.0.1
x86_64
Windows 7

Details

Attachments

(2 attachments)

(Reporter)

Description

2 years ago
Lightning 4.0a1 (Build ID 20150203030316) with Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.0a1

Steps to reproduce:
1) create new Thunderbird profile
2) install Lightning extension
3) restart Thunderbird and check error console

Console shows:
Error: ics-service doesn't recognize own tzid: floating
TypeError: aComponent is null
Source File: file:///[...]/components/calTimezoneService.js
Line: 722
(Assignee)

Comment 1

2 years ago
Related question: why are we even getting to line 722? We must be failing to get the information from the registry.
(Assignee)

Comment 2

2 years ago
Created attachment 8559439 [details] [diff] [review]
1129094-1.diff

Turns out the timezoneIds enumerator shouldn't have UTC and floating in it:
https://hg.mozilla.org/comm-central/file/61dd7dc61dc4/calendar/base/src/calTimezoneService.js#l279
Assignee: nobody → geoff
Status: NEW → ASSIGNED
Attachment #8559439 - Flags: review?(philipp)
Attachment #8559439 - Flags: review?(philipp) → review+
(Assignee)

Comment 3

2 years ago
Created attachment 8559516 [details] [diff] [review]
1129094-2.diff

Windows stopped using localized strings in this part of the registry in Vista. Fortunately they also added a new value with exactly the information we want.
Attachment #8559516 - Flags: review?(philipp)
Comment on attachment 8559516 [details] [diff] [review]
1129094-2.diff

Review of attachment 8559516 [details] [diff] [review]:
-----------------------------------------------------------------

I will be holding my hand in front of my eyes with that timezone guessing code. I wish we could just use libicu's timezone detection, which even gives us an olson name cross platform. Maybe we need to provide access to that in core.
Attachment #8559516 - Flags: review?(philipp) → review+
(Assignee)

Comment 5

2 years ago
https://hg.mozilla.org/comm-central/rev/6c4c964c3715
https://hg.mozilla.org/comm-central/rev/4aa88efb5005
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.0
You need to log in before you can comment on or make changes to this bug.